Ensure that the focus ring in the bookmarks bar does not paint outside the parent view.

ui/views/view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #define _USE_MATH_DEFINES // For VC++ to get M_PI. This has to be first.
 
 #include "ui/views/view.h"
 
 #include <algorithm>
 #include <cmath>
@@ skipping 278 matching lines @@
   // Add it in the specified index now.
   InitFocusSiblings(view, index);
   children_.insert(children_.begin() + index, view);
 
   for (ViewObserver& observer : observers_)
     observer.OnChildViewReordered(this, view);
 
   ReorderLayers();
 }
 
+void View::OnChildLayerChanged(View* child) {}
+
 void View::RemoveChildView(View* view) {
   DoRemoveChildView(view, true, true, false, NULL);
 }
 
 void View::RemoveAllChildViews(bool delete_children) {
   while (!children_.empty())
     DoRemoveChildView(children_.front(), false, false, delete_children, NULL);
   UpdateTooltip();
 }
 
@@ skipping 221 matching lines @@
       CreateLayer(ui::LAYER_TEXTURED);
     layer()->SetTransform(transform);
     layer()->ScheduleDraw();
   }
 }
 
 void View::SetPaintToLayer(ui::LayerType layer_type) {
   if (paint_to_layer_ && (layer()->type() == layer_type))
     return;
 
   DestroyLayer();

[sky, 2017/04/18 15:35:48]

When called from here DestroyLayer() should not call OnChildLayerChanged() as
otherwise SetPaintToLayer() with an existing layer results in double the calls
to OnChildLayerChanged(). It would be good to add test coverage of this.

[ananta, 2017/04/18 22:22:39]

Done.

   CreateLayer(layer_type);
   paint_to_layer_ = true;
+
+  // Notify the parent chain about the layer change.
+  NotifyParentsOfLayerChange();
 }
 
 void View::DestroyLayer() {
   if (!paint_to_layer_)
     return;
 
   paint_to_layer_ = false;
   if (!layer())
     return;
 
   ui::Layer* new_parent = layer()->parent();
   std::vector<ui::Layer*> children = layer()->children();
   for (size_t i = 0; i < children.size(); ++i) {
     layer()->Remove(children[i]);
     if (new_parent)
       new_parent->Add(children[i]);
   }
 
   LayerOwner::DestroyLayer();
 
   if (new_parent)
     ReorderLayers();
 
   UpdateChildLayerBounds(CalculateOffsetToAncestorWithLayer(NULL));
 
   SchedulePaint();
 
+  // Notify the parent chain about the layer change.
+  NotifyParentsOfLayerChange();
+
   Widget* widget = GetWidget();
   if (widget)
     widget->LayerTreeChanged();
 }
 
 std::unique_ptr<ui::Layer> View::RecreateLayer() {
   std::unique_ptr<ui::Layer> old_layer = LayerOwner::RecreateLayer();
   Widget* widget = GetWidget();
   if (widget)
     widget->LayerTreeChanged();
@@ skipping 2063 matching lines @@
 
   // Message the RootView to do the drag and drop. That way if we're removed
   // the RootView can detect it and avoid calling us back.
   gfx::Point widget_location(event.location());
   ConvertPointToWidget(this, &widget_location);
   widget->RunShellDrag(this, data, widget_location, drag_operations, source);
   // WARNING: we may have been deleted.
   return true;
 }
 
+void View::NotifyParentsOfLayerChange() {
+  // Notify the parent chain about the layer change.
+  View* view_parent = parent();
+  while (view_parent) {
+    view_parent->OnChildLayerChanged(this);
+    view_parent = view_parent->parent();
+  }
+}
+
 }  // namespace views