Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 281333002: Stop cast streaming API without start (Closed)

Created:
6 years, 7 months ago by Alpha Left Google
Modified:
6 years, 7 months ago
Reviewers:
hubbe
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, feature-media-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Stop cast streaming API without start Cast Streaming API should call stop callback only after started. BUG=373443 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270814

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -18 lines) Patch
M chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/renderer/media/cast_rtp_stream.cc View 1 chunk +2 lines, -1 line 0 comments Download
A + chrome/test/data/extensions/api_test/cast_streaming/stop_no_start.html View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/test/data/extensions/api_test/cast_streaming/stop_no_start.js View 2 chunks +11 lines, -16 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Alpha Left Google
6 years, 7 months ago (2014-05-14 21:24:29 UTC) #1
hubbe
lgtm
6 years, 7 months ago (2014-05-14 21:44:31 UTC) #2
Alpha Left Google
The CQ bit was checked by hclam@chromium.org
6 years, 7 months ago (2014-05-14 21:53:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/281333002/1
6 years, 7 months ago (2014-05-14 21:56:10 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-15 00:53:23 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-15 00:57:41 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/builds/142600)
6 years, 7 months ago (2014-05-15 00:57:41 UTC) #7
Alpha Left Google
The CQ bit was checked by hclam@chromium.org
6 years, 7 months ago (2014-05-15 20:50:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/281333002/1
6 years, 7 months ago (2014-05-15 20:51:24 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-15 21:12:26 UTC) #10
Message was sent while issue was closed. 
Change committed as 270814

Powered by Google App Engine
This is Rietveld 408576698