Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1178)

Side by Side Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp

Issue 2813303008: Remove pixel-snapping from LayoutSVGRoot::OverflowClipRect (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2007, 2008, 2009 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2007, 2008, 2009 Rob Buis <buis@kde.org>
4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org> 4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org>
5 * Copyright (C) 2009 Google, Inc. 5 * Copyright (C) 2009 Google, Inc.
6 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 6 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 218 matching lines...) Expand 10 before | Expand all | Expand 10 after
229 229
230 LayoutRect LayoutSVGRoot::VisualOverflowRect() const { 230 LayoutRect LayoutSVGRoot::VisualOverflowRect() const {
231 LayoutRect rect = LayoutReplaced::SelfVisualOverflowRect(); 231 LayoutRect rect = LayoutReplaced::SelfVisualOverflowRect();
232 if (!ShouldApplyViewportClip()) 232 if (!ShouldApplyViewportClip())
233 rect.Unite(ContentsVisualOverflowRect()); 233 rect.Unite(ContentsVisualOverflowRect());
234 return rect; 234 return rect;
235 } 235 }
236 236
237 LayoutRect LayoutSVGRoot::OverflowClipRect(const LayoutPoint& location, 237 LayoutRect LayoutSVGRoot::OverflowClipRect(const LayoutPoint& location,
238 OverlayScrollbarClipBehavior) const { 238 OverlayScrollbarClipBehavior) const {
239 return LayoutRect(PixelSnappedIntRect(LayoutReplaced::OverflowClipRect( 239 return LayoutReplaced::OverflowClipRect(location,
pdr. 2017/04/17 20:12:20 How does this not change test results? Can we rem
240 location, kIgnorePlatformOverlayScrollbarSize))); 240 kIgnorePlatformOverlayScrollbarSize);
241 } 241 }
242 242
243 void LayoutSVGRoot::PaintReplaced(const PaintInfo& paint_info, 243 void LayoutSVGRoot::PaintReplaced(const PaintInfo& paint_info,
244 const LayoutPoint& paint_offset) const { 244 const LayoutPoint& paint_offset) const {
245 SVGRootPainter(*this).PaintReplaced(paint_info, paint_offset); 245 SVGRootPainter(*this).PaintReplaced(paint_info, paint_offset);
246 } 246 }
247 247
248 void LayoutSVGRoot::WillBeDestroyed() { 248 void LayoutSVGRoot::WillBeDestroyed() {
249 SVGResourcesCache::ClientDestroyed(this); 249 SVGResourcesCache::ClientDestroyed(this);
250 LayoutReplaced::WillBeDestroyed(); 250 LayoutReplaced::WillBeDestroyed();
(...skipping 241 matching lines...) Expand 10 before | Expand all | Expand 10 after
492 if (result.AddNodeToListBasedTestResult(GetNode(), location_in_container, 492 if (result.AddNodeToListBasedTestResult(GetNode(), location_in_container,
493 bounds_rect) == kStopHitTesting) 493 bounds_rect) == kStopHitTesting)
494 return true; 494 return true;
495 } 495 }
496 } 496 }
497 497
498 return false; 498 return false;
499 } 499 }
500 500
501 } // namespace blink 501 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698