media/gpu/avda_surface_bundle.cc - Issue 2813303003: Add AndroidVideoSurfaceChooser to manage overlays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/gpu/avda_surface_bundle.cc

Issue 2813303003: Add AndroidVideoSurfaceChooser to manage overlays. (Closed)

Patch Set: fixed dereference of base::Optional Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/gpu/avda_surface_bundle.cc

diff --git a/media/gpu/avda_surface_bundle.cc b/media/gpu/avda_surface_bundle.cc

index 608519bb936e3f4163421d2cc3f57fbea95a7554..9d0f3624fe5d9e543797391745cea2d8ed754824 100644

--- a/media/gpu/avda_surface_bundle.cc

+++ b/media/gpu/avda_surface_bundle.cc

@@ -7,7 +7,8 @@

namespace media {

-AVDASurfaceBundle::AVDASurfaceBundle(int surface_id) : surface_id(surface_id) {}

+AVDASurfaceBundle::AVDASurfaceBundle(std::unique_ptr<AndroidOverlay> overlay)

+ : overlay(std::move(overlay)) {}

AVDASurfaceBundle::~AVDASurfaceBundle() {

// Explicitly free the surface first, just to be sure that it's deleted before

« no previous file with comments | « media/gpu/avda_surface_bundle.h ('k') | media/gpu/content_video_view_overlay_factory.h » ('j') | no next file with comments »