Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Unified Diff: media/gpu/avda_codec_allocator.h

Issue 2813303003: Add AndroidVideoSurfaceChooser to manage overlays. (Closed)
Patch Set: fixed dereference of base::Optional Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/gpu/android_video_surface_chooser_impl_unittest.cc ('k') | media/gpu/avda_surface_bundle.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/gpu/avda_codec_allocator.h
diff --git a/media/gpu/avda_codec_allocator.h b/media/gpu/avda_codec_allocator.h
index be1d61396c481b8df9e95e74324c76ddc4029537..5a598b088abfd4cb832edb7314970f2e32898ea8 100644
--- a/media/gpu/avda_codec_allocator.h
+++ b/media/gpu/avda_codec_allocator.h
@@ -123,7 +123,7 @@ class MEDIA_GPU_EXPORT AVDACodecAllocator {
void StopThread(AVDACodecAllocatorClient* client);
// Create and configure a MediaCodec synchronously.
- std::unique_ptr<MediaCodecBridge> CreateMediaCodecSync(
+ virtual std::unique_ptr<MediaCodecBridge> CreateMediaCodecSync(
scoped_refptr<CodecConfig> codec_config);
// Create and configure a MediaCodec asynchronously. The result is delivered
@@ -140,7 +140,7 @@ class MEDIA_GPU_EXPORT AVDACodecAllocator {
// that it outlives |media_codec|.
// TODO(watk): Bundle the MediaCodec and surface together so you can't get
// this pairing wrong.
- void ReleaseMediaCodec(
+ virtual void ReleaseMediaCodec(
std::unique_ptr<MediaCodecBridge> media_codec,
TaskType task_type,
const scoped_refptr<AVDASurfaceBundle>& surface_bundle);
« no previous file with comments | « media/gpu/android_video_surface_chooser_impl_unittest.cc ('k') | media/gpu/avda_surface_bundle.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698