Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1994)

Unified Diff: runtime/vm/thread_pool.cc

Issue 2813283002: Add --print_stacktrace_at_api_error. (Closed)
Patch Set: . Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/profiler.cc ('K') | « runtime/vm/profiler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/thread_pool.cc
diff --git a/runtime/vm/thread_pool.cc b/runtime/vm/thread_pool.cc
index 8050833851e76dcf9ebf7ad25252bb842e24aa91..4c73446f0c5f78fd240f766636d228d47a976a6e 100644
--- a/runtime/vm/thread_pool.cc
+++ b/runtime/vm/thread_pool.cc
@@ -447,7 +447,10 @@ void ThreadPool::Worker::Main(uword args) {
ThreadPool* pool;
// Set the thread's stack_base based on the current stack pointer.
- os_thread->set_stack_base(Thread::GetCurrentStackPointer());
+ uword current_sp = Thread::GetCurrentStackPointer();
+ if (current_sp > os_thread->stack_base()) {
+ os_thread->set_stack_base(current_sp);
+ }
siva 2017/04/13 01:50:18 Which situation causes the code inside the 'if' st
{
MonitorLocker ml(&worker->monitor_);
« runtime/vm/profiler.cc ('K') | « runtime/vm/profiler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698