Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1150)

Unified Diff: chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_mac.cc

Issue 2813273003: Update the binary integrity incident designated requirement. (Closed)
Patch Set: Update the binary integrity incident designated requirement. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_mac_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_mac.cc
diff --git a/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_mac.cc b/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_mac.cc
index 80dc4812b6f5b62a63cf1c0cd6a389a1aaf2178f..0d619b9ee7976954cfa9db261e2da1ad4e2ca036 100644
--- a/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_mac.cc
+++ b/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_mac.cc
@@ -16,9 +16,6 @@
#include "chrome/browser/safe_browsing/signature_evaluator_mac.h"
#include "components/safe_browsing/csd.pb.h"
-#define DEVELOPER_ID_APPLICATION_OID "field.1.2.840.113635.100.6.1.13"
-#define DEVELOPER_ID_INTERMEDIATE_OID "field.1.2.840.113635.100.6.2.6"
-
namespace safe_browsing {
namespace {
@@ -53,11 +50,12 @@ std::vector<PathAndRequirement> GetCriticalPathsAndRequirements() {
// with Google's team identifier, and the com.Google.Chrome[.canary]
// identifier.
std::string requirement =
- "anchor apple generic and certificate 1[" DEVELOPER_ID_INTERMEDIATE_OID
- "] exists and certificate leaf[" DEVELOPER_ID_APPLICATION_OID
- "] exists and certificate leaf[subject.OU]=\"EQHXZ8M8AV\" and "
- "(identifier=\"com.google.Chrome\" or "
- "identifier=\"com.google.Chrome.canary\")";
+ "(identifier \"com.google.Chrome\" or "
+ "identifier \"com.google.Chrome.beta\" or "
+ "identifier \"com.google.Chrome.dev\" or "
+ "identifier \"com.google.Chrome.canary\") "
+ "and certificate leaf = H\"c9a99324ca3fcb23dbcc36bd5fd4f9753305130a\")";
+
critical_binaries.push_back(
PathAndRequirement(base::mac::OuterBundlePath(), requirement));
// TODO(kerrnel): eventually add Adobe Flash Player to this list.
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_mac_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698