network service: pass PlzNavigate resulting data via mojo data pipe

content/child/web_url_loader_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/child/web_url_loader_impl.h"
 
 #include <stdint.h>
 
 #include <algorithm>
 #include <memory>
@@ skipping 584 matching lines @@
       (url.has_username() || url.has_password())) {
     resource_request->do_not_prompt_for_login = true;
   }
   resource_request->report_raw_headers = request.ReportRawHeaders();
   resource_request->previews_state =
       static_cast<PreviewsState>(request.GetPreviewsState());
 
   // PlzNavigate: during navigation, the renderer should request a stream which
   // contains the body of the response. The network request has already been
   // made by the browser.
+  mojo::ScopedDataPipeConsumerHandle consumer_handle;
   if (stream_override_.get()) {
     CHECK(IsBrowserSideNavigationEnabled());
     DCHECK(!sync_load_response);
     DCHECK_NE(WebURLRequest::kFrameTypeNone, request.GetFrameType());
-    resource_request->resource_body_stream_url = stream_override_->stream_url;
+    if (stream_override_->consumer_handle.is_valid()) {
+      consumer_handle = std::move(stream_override_->consumer_handle);
+    } else {
+      resource_request->resource_body_stream_url = stream_override_->stream_url;
+    }
   }
 
   // PlzNavigate: Invalid renderer main resource requests are rejected by the
   // browser. This should not happen.
   // TODO(arthursonzogni): Remove this when the root cause for
   // https://crbug.com/705508 is found.
   if (IsBrowserSideNavigationEnabled() &&
       IsResourceTypeFrame(resource_request->resource_type) &&
       !resource_request->resource_body_stream_url.SchemeIs(url::kBlobScheme)) {
     base::debug::DumpWithoutCrashing();
@@ skipping 14 matching lines @@
         request.GetLoadingIPCType(), url_loader_factory_);
     return;
   }
 
   TRACE_EVENT_WITH_FLOW0("loading", "WebURLLoaderImpl::Context::Start", this,
                          TRACE_EVENT_FLAG_FLOW_OUT);
   request_id_ = resource_dispatcher_->StartAsync(
       std::move(resource_request), request.RequestorID(), task_runner_,
       extra_data->frame_origin(),
       base::MakeUnique<WebURLLoaderImpl::RequestPeerImpl>(this),
-      request.GetLoadingIPCType(), url_loader_factory_);
+      request.GetLoadingIPCType(), url_loader_factory_,
+      std::move(consumer_handle));
 
   if (defers_loading_ != NOT_DEFERRING)
     resource_dispatcher_->SetDefersLoading(request_id_, true);
 }
 
 void WebURLLoaderImpl::Context::SetTaskRunner(
     const scoped_refptr<base::SingleThreadTaskRunner>& task_runner) {
   task_runner_ = task_runner;
 }
 
@@ skipping 146 matching lines @@
     client_->DidDownloadData(len, encoded_data_length);
 }
 
 void WebURLLoaderImpl::Context::OnReceivedData(
     std::unique_ptr<ReceivedData> data) {
   const char* payload = data->payload();
   int data_length = data->length();
   if (!client_)
     return;
 
+  if (stream_override_.get()) {
+    // Since ResourceDispatcher::ContinueForNavigation called OnComplete

[jam, 2017/04/12 20:49:17]

nit: i would put this inside the next if statement, as only then is data pipe
being used

[scottmg, 2017/04/12 20:51:38]

Should be if (a&&b) anyway, fixed.

+    // immediately, it didn't have the size of the resource immediately. So as
+    // data is read off the data pipe, keep track of how much we're reading.
+    if (stream_override_->stream_url.is_empty()) {
+      stream_override_->total_transferred += data_length;
+    }
+  }
+
   TRACE_EVENT_WITH_FLOW0(
       "loading", "WebURLLoaderImpl::Context::OnReceivedData",
       this, TRACE_EVENT_FLAG_FLOW_IN | TRACE_EVENT_FLAG_FLOW_OUT);
 
   if (ftp_listing_delegate_) {
     // The FTP listing delegate will make the appropriate calls to
     // client_->didReceiveData and client_->didReceiveResponse.
     ftp_listing_delegate_->OnReceivedData(payload, data_length);
   } else {
     // We dispatch the data even when |useStreamOnResponse()| is set, in order
@@ skipping 22 matching lines @@
   client_->DidReceiveCachedMetadata(data, len);
 }
 
 void WebURLLoaderImpl::Context::OnCompletedRequest(
     int error_code,
     bool was_ignored_by_handler,
     bool stale_copy_in_cache,
     const base::TimeTicks& completion_time,
     int64_t total_transfer_size,
     int64_t encoded_body_size) {
+  if (stream_override_.get()) {
+    if (stream_override_->stream_url.is_empty()) {
+      // TODO(kinuko|scottmg|jam): This is wrong. https://crbug.com/598073.

[jam, 2017/04/12 20:49:17]

nit: 598073 is for network service, while this code is for plznavigate. so i'd
either take out that bug or make a new one to track this

[scottmg, 2017/04/12 20:51:38]

Put it on the data pipe one, 705744.

+      total_transfer_size = stream_override_->total_transferred;
+      encoded_body_size = stream_override_->total_transferred;
+    }
+  }
+
   if (ftp_listing_delegate_) {
     ftp_listing_delegate_->OnCompletedRequest();
     ftp_listing_delegate_.reset(NULL);
   }
 
   if (body_stream_writer_ && error_code != net::OK)
     body_stream_writer_->Fail();
   body_stream_writer_.reset();
 
   if (client_) {
@@ skipping 394 matching lines @@
                                          int intra_priority_value) {
   context_->DidChangePriority(new_priority, intra_priority_value);
 }
 
 void WebURLLoaderImpl::SetLoadingTaskRunner(
     base::SingleThreadTaskRunner* loading_task_runner) {
   context_->SetTaskRunner(loading_task_runner);
 }
 
 }  // namespace content