Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

Issue 2813173002: webkitpy: Rework the JSON output flags. (Closed)
Patch Set: Fixing for review. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
index c5fe3cdfcafb1050000160ed21ae32c0527dfed1..aec5831a0a37beb3fd600488ad68dc540a2ba7cd 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
@@ -164,9 +164,14 @@ def parse_args(args):
default=False,
help='Show all failures in results.html, rather than only regressions'),
optparse.make_option(
- '--json-test-results',
- action='store',
- help='Path to write the JSON test results to.'),
+ '--json-test-results', # New name from json_results_generator
+ '--write-full-results-to', # Old argument name
+ '--isolated-script-test-output', # Isolated API
+ help='Path to write the JSON test results for *all* tests.'),
+ # FIXME(tansell): Remove this option if nobody is found who needs it.
+ optparse.make_option(
+ '--json-failing-test-results',
+ help='Path to write the JSON test results for only *failing* tests.'),
optparse.make_option(
'--new-baseline',
action='store_true',
@@ -466,10 +471,6 @@ def parse_args(args):
'--test-results-server',
default='',
help='If specified, upload results json files to this appengine server.'),
- optparse.make_option(
- '--write-full-results-to',
- help=('If specified, copy full_results.json from the results dir to the '
- 'specified path.')),
]))
option_parser = optparse.OptionParser()

Powered by Google App Engine
This is Rietveld 408576698