third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py - Issue 2813173002: webkitpy: Rework the JSON output flags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

Issue 2813173002: webkitpy: Rework the JSON output flags. (Closed)

Patch Set: Small fixes Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

index c5fe3cdfcafb1050000160ed21ae32c0527dfed1..83536460051a4568aa79877ef3514c21457ceff4 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

@@ -164,9 +164,14 @@ def parse_args(args):

default=False,

help='Show all failures in results.html, rather than only regressions'),

optparse.make_option(

- '--json-test-results',

- action='store',

- help='Path to write the JSON test results to.'),

+ '--json-test-results', # New name from json_results_generator

+ '--write-full-results-to', # Old argument name

+ '--isolated-script-test-output', # Isolated API

+ help=('Path to write the JSON test results for *all* tests.')),

qyearsley 2017/04/12 19:28:15 Nit: parentheses after help= could be removed

mithro 2017/04/13 02:56:07 Done.

+ # FIXME(tansell): Remove this option if nobody is found who needs it.

+ optparse.make_option(

+ '--json-failing-test-results',

+ help=('Path to write the JSON test results for only *failing* tests.')),

qyearsley 2017/04/12 19:28:15 I bet this could also be removed now, since I don'

mithro 2017/04/13 02:56:07 Yeah, lets leave it for now.

optparse.make_option(

'--new-baseline',

action='store_true',

@@ -466,10 +471,6 @@ def parse_args(args):

'--test-results-server',

default='',

help='If specified, upload results json files to this appengine server.'),

- optparse.make_option(

- '--write-full-results-to',

- help=('If specified, copy full_results.json from the results dir to the '

- 'specified path.')),

]))

option_parser = optparse.OptionParser()