Adding ArcBridge Interface for Volume Update Requests

components/arc/audio/arc_audio_bridge.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/arc/audio/arc_audio_bridge.h"
 
 #include "ash/common/system/chromeos/audio/tray_audio.h"
 #include "base/logging.h"
 #include "chromeos/audio/audio_device.h"
 #include "components/arc/arc_bridge_service.h"
@@ skipping 21 matching lines @@
       ARC_GET_INSTANCE_FOR_METHOD(arc_bridge_service()->audio(), Init);
   DCHECK(audio_instance);  // the instance on ARC side is too old.
   audio_instance->Init(binding_.CreateInterfacePtrAndBind());
 }
 
 void ArcAudioBridge::ShowVolumeControls() {
   DVLOG(2) << "ArcAudioBridge::ShowVolumeControls";
   ash::TrayAudio::ShowPopUpVolumeView();
 }
 
+void ArcAudioBridge::OnVolumeUpdateRequest(float volume) {
+  cras_audio_handler_->SetOutputVolumePercent(volume);

[dcheng, 2017/04/14 03:36:42]

This should check that the input is in range.

(Out of curiosity, why a float and not an int?)

[yueli, 2017/06/02 19:10:13]

It seems the range is already handled in SetOutputNodeVolumePercent.
As for the float value, just want to provide the more accurate value. But since
we can only set volume by int, it also make sense to just send an int.

[dcheng, 2017/06/02 23:25:35]

This is OK, but I will note that it makes it a bit confusing when validation is
handled at different layers. I wouldn't have expected SetOuputNodeVolumePercent
to have to try to handle bad inputs gracefully, but I don't understand the CrOS
layering well enough to comment more.
I don't see any changes in this CL, does this comment mean that we're planning
on changing this to pass an int?

[yueli, 2017/06/06 16:43:09]

Done.

+  bool is_muted =
+      volume <= cras_audio_handler_->GetOutputDefaultVolumeMuteThreshold();
+  if (cras_audio_handler_->IsOutputMuted() != is_muted)
+    cras_audio_handler_->SetOutputMute(is_muted);
+}
+
 void ArcAudioBridge::OnAudioNodesChanged() {
   uint64_t output_id = cras_audio_handler_->GetPrimaryActiveOutputNode();
   const chromeos::AudioDevice* output_device =
       cras_audio_handler_->GetDeviceFromId(output_id);
   bool headphone_inserted =
       (output_device &&
        output_device->type == chromeos::AudioDeviceType::AUDIO_TYPE_HEADPHONE);
 
   uint64_t input_id = cras_audio_handler_->GetPrimaryActiveInputNode();
   const chromeos::AudioDevice* input_device =
@@ skipping 40 matching lines @@
 
 void ArcAudioBridge::SendVolumeState() {
   DVLOG(1) << "Send volume " << volume_ << " muted " << muted_;
   mojom::AudioInstance* audio_instance = ARC_GET_INSTANCE_FOR_METHOD(
       arc_bridge_service()->audio(), NotifyVolumeState);
   if (audio_instance)
     audio_instance->NotifyVolumeState(volume_, muted_);
 }
 
 }  // namespace arc