VR: Stop mouse move events when scrolling/fling

content/browser/renderer_host/render_widget_host_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_impl.h"
 
 #include <math.h>
 
 #include <set>
 #include <tuple>
@@ skipping 264 matching lines @@
       ignore_input_events_(false),
       text_direction_updated_(false),
       text_direction_(blink::WebTextDirectionLeftToRight),
       text_direction_canceled_(false),
       suppress_events_until_keydown_(false),
       pending_mouse_lock_request_(false),
       allow_privileged_mouse_lock_(false),
       has_touch_handler_(false),
       is_in_touchpad_gesture_scroll_(false),
       is_in_touchscreen_gesture_scroll_(false),
+      is_in_touchpad_gesture_fling_(false),
       latency_tracker_(),
       next_browser_snapshot_id_(1),
       owned_by_render_frame_host_(false),
       is_focused_(false),
       hung_renderer_delay_(
           base::TimeDelta::FromMilliseconds(kHungRendererDelayMs)),
       hang_monitor_event_type_(blink::WebInputEvent::Undefined),
       last_event_type_(blink::WebInputEvent::Undefined),
       new_content_rendering_delay_(
           base::TimeDelta::FromMilliseconds(kNewContentRenderingDelayMs)),
@@ skipping 716 matching lines @@
   // It is possible for a compositor frame to arrive before the browser is
   // notified about the page being committed, in which case no timer is
   // necessary.
   if (last_received_content_source_id_ >= current_content_source_id_)
     return;
 
   new_content_rendering_timeout_->Start(new_content_rendering_delay_);
 }
 
 void RenderWidgetHostImpl::ForwardMouseEvent(const WebMouseEvent& mouse_event) {
+  if (GetView()->IsInVR() &&

[dtapuska, 2017/04/13 14:48:25]

Can we put a comment here indicating why we are doing this?

[asimjour1, 2017/04/13 16:31:35]

Done.

+      (is_in_touchpad_gesture_scroll_ || is_in_touchpad_gesture_fling_)) {
+    return;
+  }
+
   ForwardMouseEventWithLatencyInfo(mouse_event,
                                    ui::LatencyInfo(ui::SourceEventType::OTHER));
   if (owner_delegate_)
     owner_delegate_->RenderWidgetDidForwardMouseEvent(mouse_event);
 }
 
 void RenderWidgetHostImpl::ForwardMouseEventWithLatencyInfo(
       const blink::WebMouseEvent& mouse_event,
       const ui::LatencyInfo& ui_latency) {
   TRACE_EVENT2("input", "RenderWidgetHostImpl::ForwardMouseEvent", "x",
@@ skipping 73 matching lines @@
     *is_in_gesture_scroll = true;
   } else if (gesture_event.type() == blink::WebInputEvent::GestureScrollEnd ||
              gesture_event.type() == blink::WebInputEvent::GestureFlingStart) {
     // TODO(wjmaclean): Re-enable the following DCHECK once crbug.com/695187
     // is fixed.
     // DCHECK(*is_in_gesture_scroll ||
     //       (gesture_event.type() == blink::WebInputEvent::GestureFlingStart &&
     //        gesture_event.sourceDevice ==
     //            blink::WebGestureDevice::WebGestureDeviceTouchpad));
     *is_in_gesture_scroll = false;
+    if (gesture_event.type() == blink::WebInputEvent::GestureFlingStart)

[dtapuska, 2017/04/13 14:48:25]

I think this needs a check that the source device is touchpad no?

[asimjour1, 2017/04/13 16:31:35]

Done.

+      is_in_touchpad_gesture_fling_ = true;
   }
 
   bool scroll_update_needs_wrapping =
       gesture_event.type() == blink::WebInputEvent::GestureScrollUpdate &&
       gesture_event.resendingPluginId != -1 && !(*is_in_gesture_scroll);
 
   // TODO(crbug.com/544782): Fix WebViewGuestScrollTest.TestGuestWheelScrolls-
   // Bubble to test the resending logic of gesture events.
   if (scroll_update_needs_wrapping) {
     ForwardGestureEventWithLatencyInfo(
@@ skipping 1088 matching lines @@
     synthetic_gesture_controller_->OnDidFlushInput();
 }
 
 void RenderWidgetHostImpl::DidOverscroll(
     const ui::DidOverscrollParams& params) {
   if (view_)
     view_->DidOverscroll(params);
 }
 
 void RenderWidgetHostImpl::DidStopFlinging() {
+  is_in_touchpad_gesture_fling_ = false;
   if (view_)
     view_->DidStopFlinging();
 }
 
 void RenderWidgetHostImpl::DispatchInputEventWithLatencyInfo(
     const blink::WebInputEvent& event,
     ui::LatencyInfo* latency) {
   latency_tracker_.OnInputEvent(event, latency);
   for (auto& observer : input_event_observers_)
     observer.OnInputEvent(event);
@@ skipping 481 matching lines @@
   RenderProcessHost* rph = GetProcess();
   for (std::vector<IPC::Message>::const_iterator i = messages.begin();
        i != messages.end(); ++i) {
     rph->OnMessageReceived(*i);
     if (i->dispatch_error())
       rph->OnBadMessageReceived(*i);
   }
 }
 
 }  // namespace content