Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2813093002: Remove BackendClasses and JavaScriptBackendClasses. (Closed)

Created:
3 years, 8 months ago by Emily Fortuna
Modified:
3 years, 8 months ago
Reviewers:
Johnni Winther, sra1
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 : . #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+233 lines, -514 lines) Patch
M pkg/compiler/lib/src/common/backend_api.dart View 1 2 1 chunk +0 lines, -129 lines 0 comments Download
M pkg/compiler/lib/src/common_elements.dart View 1 2 2 chunks +28 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/compile_time_constants.dart View 4 chunks +2 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/constant_system_dart.dart View 1 2 2 chunks +5 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/constants/constant_system.dart View 2 chunks +4 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/constants/evaluation.dart View 2 chunks +0 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/constants/expressions.dart View 3 chunks +4 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/node_tracer.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_nodes.dart View 1 3 chunks +5 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 10 chunks +3 lines, -100 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen_listener.dart View 1 5 chunks +2 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_system_javascript.dart View 1 2 4 chunks +6 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart View 1 6 chunks +6 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart View 1 6 chunks +3 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/resolution_listener.dart View 1 5 chunks +2 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/kernel/world_builder.dart View 1 5 chunks +7 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/native/behavior.dart View 1 9 chunks +12 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/native/enqueue.dart View 1 5 chunks +5 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/ssa/interceptor_simplifier.dart View 1 7 chunks +20 lines, -23 lines 0 comments Download
M pkg/compiler/lib/src/ssa/invoke_dynamic_specializers.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 4 chunks +9 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/ssa/nodes.dart View 3 chunks +32 lines, -31 lines 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/types/flat_type_mask.dart View 3 chunks +20 lines, -24 lines 0 comments Download
M pkg/compiler/lib/src/types/map_type_mask.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/types/masks.dart View 6 chunks +44 lines, -41 lines 0 comments Download
M pkg/compiler/lib/src/universe/function_set.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/world.dart View 1 2 3 chunks +0 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/constant_expression_evaluate_test.dart View 1 1 chunk +0 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/field_type_simple_inferer_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/kernel/closed_world2_test.dart View 1 2 2 chunks +2 lines, -11 lines 0 comments Download
M tests/compiler/dart2js/kernel/closed_world_test.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
M tests/compiler/dart2js/simple_inferrer_final_field2_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/type_mask2_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Emily Fortuna
3 years, 8 months ago (2017-04-12 01:23:59 UTC) #2
Emily Fortuna
PTAL
3 years, 8 months ago (2017-04-12 19:50:24 UTC) #6
sra1
lgtm
3 years, 8 months ago (2017-04-12 20:16:22 UTC) #7
Johnni Winther
LGTM I think you can delete BackendClasses in common/backend_api.dart as well.
3 years, 8 months ago (2017-04-13 20:24:34 UTC) #8
Emily Fortuna
3 years, 8 months ago (2017-04-14 00:23:00 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:80001) manually as
93a908fde01a29bda1358db930efe81f1886e670 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698