Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: components/safe_browsing/csd.proto

Issue 2813063003: Deprecate cache_expression_exact_match (Closed)
Patch Set: refine comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/safe_browsing/password_protection/password_protection_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/safe_browsing/csd.proto
diff --git a/components/safe_browsing/csd.proto b/components/safe_browsing/csd.proto
index 04316444ad1f5cee083f23767842394f203f5f9a..b5120e5261fc61df9f7c069b4e64cd372e824876 100644
--- a/components/safe_browsing/csd.proto
+++ b/components/safe_browsing/csd.proto
@@ -248,18 +248,7 @@ message LoginReputationClientResponse {
// a substring of page_url.
optional string cache_expression = 3;
- // If set true, we match target URL with cache expression up to both of their
- // last /'s.
- //
- // Examples:
- // If set true, a cache_expression "foo.com/bar" will match
- // "foo.com/bar",
- // "foo.com/bar/bar.cgi",
- // "foo.com/bar/login.html?param=val",
- // but will NOT match
- // "foo.com",
- // "foo.com/abc/",
- // "foo.com/bar/abc/edf.cgi"
+ // Deprecated.
optional bool cache_expression_exact_match = 4;
lpz 2017/04/12 18:45:21 rename DEPRECATED_cache_expression_exact_match to
Jialiu Lin 2017/04/12 19:33:17 Done. Also added "[deprecated = true]"
}
« no previous file with comments | « no previous file | components/safe_browsing/password_protection/password_protection_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698