Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6873)

Unified Diff: chrome/browser/resources/settings/site_settings_page/site_settings_page.html

Issue 2813033004: MD Settings: Restore focus after exiting Content settings sub-subpages. (Closed)
Patch Set: Address comments. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/site_settings_page/site_settings_page.html
diff --git a/chrome/browser/resources/settings/site_settings_page/site_settings_page.html b/chrome/browser/resources/settings/site_settings_page/site_settings_page.html
index 7dee54ee4efbaf9f03118d5daa5600257a8ad889..8451c84573a3da3fdb1ff1318fd0f71748f75fb6 100644
--- a/chrome/browser/resources/settings/site_settings_page/site_settings_page.html
+++ b/chrome/browser/resources/settings/site_settings_page/site_settings_page.html
@@ -26,7 +26,7 @@
<div class="settings-box line-only">
</div>
</template>
- <div class="settings-box two-line first"
+ <div id="cookies" class="settings-box two-line first"
category$="[[ContentSettingsTypes.COOKIES]]"
data-route="SITE_SETTINGS_COOKIES" on-tap="onTapNavigate_" actionable>
<iron-icon icon="settings:cookie"></iron-icon>
@@ -44,7 +44,7 @@
aria-label="$i18n{siteSettingsCookies}"
aria-describedby="cookiesSecondary"></button>
</div>
- <div class="settings-box two-line"
+ <div id="location" class="settings-box two-line"
category$="[[ContentSettingsTypes.GEOLOCATION]]"
data-route="SITE_SETTINGS_LOCATION" on-tap="onTapNavigate_" actionable>
<iron-icon icon="settings:location-on"></iron-icon>
@@ -61,7 +61,7 @@
aria-label="$i18n{siteSettingsLocation}"
aria-describedby="locationSecondary"></button>
</div>
- <div class="settings-box two-line"
+ <div id="camera" class="settings-box two-line"
category$="[[ContentSettingsTypes.CAMERA]]"
data-route="SITE_SETTINGS_CAMERA"
on-tap="onTapNavigate_" actionable>
@@ -79,7 +79,8 @@
aria-label="$i18n{siteSettingsCamera}"
aria-describedby="cameraSecondary"></button>
</div>
- <div class="settings-box two-line" category$="[[ContentSettingsTypes.MIC]]"
+ <div id="microphone" class="settings-box two-line"
+ category$="[[ContentSettingsTypes.MIC]]"
data-route="SITE_SETTINGS_MICROPHONE" on-tap="onTapNavigate_"
actionable>
<iron-icon icon="settings:mic"></iron-icon>
@@ -96,7 +97,7 @@
aria-label="$i18n{siteSettingsMic}"
aria-describedby="micSecondary"></button>
</div>
- <div class="settings-box two-line"
+ <div id="notifications" class="settings-box two-line"
category$="[[ContentSettingsTypes.NOTIFICATIONS]]"
data-route="SITE_SETTINGS_NOTIFICATIONS" on-tap="onTapNavigate_"
actionable>
@@ -114,7 +115,7 @@
aria-label="$i18n{siteSettingsNotifications}"
aria-describedby="notificationsSecondary"></button>
</div>
- <div class="settings-box two-line"
+ <div id="javascript" class="settings-box two-line"
category$="[[ContentSettingsTypes.JAVASCRIPT]]"
data-route="SITE_SETTINGS_JAVASCRIPT" on-tap="onTapNavigate_"
actionable>
@@ -132,7 +133,7 @@
aria-label="$i18n{siteSettingsJavascript}"
aria-describedby="javascriptSecondary"></button>
</div>
- <div class="settings-box two-line"
+ <div id="flash" class="settings-box two-line"
category$="[[ContentSettingsTypes.PLUGINS]]"
data-route="SITE_SETTINGS_FLASH" on-tap="onTapNavigate_" actionable>
<iron-icon icon="cr:extension"></iron-icon>
@@ -150,7 +151,7 @@
aria-label="$i18n{siteSettingsFlash}"
aria-describedby="flashSecondary"></button>
</div>
- <div class="settings-box two-line"
+ <div id="images" class="settings-box two-line"
category$="[[ContentSettingsTypes.IMAGES]]"
data-route="SITE_SETTINGS_IMAGES" on-tap="onTapNavigate_" actionable>
<iron-icon icon="settings:photo"></iron-icon>
@@ -167,7 +168,7 @@
aria-label="$i18n{siteSettingsImages}"
aria-describedby="imagesSecondary"></button>
</div>
- <div category$="[[ContentSettingsTypes.POPUPS]]"
+ <div id="popups" category$="[[ContentSettingsTypes.POPUPS]]"
class="settings-box two-line" data-route="SITE_SETTINGS_POPUPS"
on-tap="onTapNavigate_" actionable>
<iron-icon icon="cr:open-in-new"></iron-icon>
@@ -185,7 +186,7 @@
aria-describedby="popupsSecondary"></button>
</div>
<template is="dom-if" if="[[enableSafeBrowsingSubresourceFilter_]]">
- <div class="settings-box two-line"
+ <div id="subresource-filter" class="settings-box two-line"
category$="[[ContentSettingsTypes.SUBRESOURCE_FILTER]]"
data-route="SITE_SETTINGS_SUBRESOURCE_FILTER" on-tap="onTapNavigate_"
actionable>
@@ -204,7 +205,7 @@
aria-describedby="subresourceFilterSecondary"></button>
</div>
</template>
- <div class="settings-box two-line"
+ <div id="background-sync" class="settings-box two-line"
category$="[[ContentSettingsTypes.BACKGROUND_SYNC]]"
data-route="SITE_SETTINGS_BACKGROUND_SYNC" on-tap="onTapNavigate_"
actionable>
@@ -222,7 +223,7 @@
aria-label="$i18n{siteSettingsBackgroundSync}"
aria-describedby="backgroundSyncSecondary"></button>
</div>
- <div class="settings-box two-line"
+ <div id="automatic-downloads" class="settings-box two-line"
category$="[[ContentSettingsTypes.AUTOMATIC_DOWNLOADS]]"
data-route="SITE_SETTINGS_AUTOMATIC_DOWNLOADS"
on-tap="onTapNavigate_" actionable>
@@ -240,7 +241,7 @@
aria-label="$i18n{siteSettingsAutomaticDownloads}"
aria-describedby="automaticDownloadsSecondary"></button>
</div>
- <div class="settings-box two-line"
+ <div id="unsandboxed-plugins" class="settings-box two-line"
category$="[[ContentSettingsTypes.UNSANDBOXED_PLUGINS]]"
data-route="SITE_SETTINGS_UNSANDBOXED_PLUGINS"
on-tap="onTapNavigate_" actionable>
@@ -259,7 +260,7 @@
aria-describedby="unsandboxedPluginsSecondary"></button>
</div>
<template is="dom-if" if="[[!isGuest_]]">
- <div class="settings-box two-line"
+ <div id="protocol-handlers" class="settings-box two-line"
category$="[[ContentSettingsTypes.PROTOCOL_HANDLERS]]"
data-route="SITE_SETTINGS_HANDLERS"
on-tap="onTapNavigate_" actionable>
@@ -278,7 +279,7 @@
aria-describedby="handlersSecondary"></button>
</div>
</template>
- <div class="settings-box two-line"
+ <div id="midi-devices" class="settings-box two-line"
category$="[[ContentSettingsTypes.MIDI_DEVICES]]"
data-route="SITE_SETTINGS_MIDI_DEVICES"
on-tap="onTapNavigate_" actionable>
@@ -296,31 +297,35 @@
aria-label="$i18n{siteSettingsMidiDevices}"
aria-describedby="midiDevicesSecondary"></button>
</div>
- <div class="settings-box" category$="[[ContentSettingsTypes.ZOOM_LEVELS]]"
- data-route="SITE_SETTINGS_ZOOM_LEVELS"
- on-tap="onTapNavigate_" actionable>
+ <div id="zoom-levels" class="settings-box"
+ category$="[[ContentSettingsTypes.ZOOM_LEVELS]]"
+ data-route="SITE_SETTINGS_ZOOM_LEVELS" on-tap="onTapNavigate_"
+ actionable>
<iron-icon icon="settings:zoom-in"></iron-icon>
<div class="middle">$i18n{siteSettingsZoomLevels}</div>
<button class="subpage-arrow" is="paper-icon-button-light"
aria-label="$i18n{siteSettingsZoomLevels}"></button>
</div>
- <div class="settings-box" category$="[[ContentSettingsTypes.USB_DEVICES]]"
- data-route="SITE_SETTINGS_USB_DEVICES"
- on-tap="onTapNavigate_" actionable>
+ <div id="usb-devices" class="settings-box"
+ category$="[[ContentSettingsTypes.USB_DEVICES]]"
+ data-route="SITE_SETTINGS_USB_DEVICES" on-tap="onTapNavigate_"
+ actionable>
<iron-icon icon="settings:usb"></iron-icon>
<div class="middle">$i18n{siteSettingsUsbDevices}</div>
<button class="subpage-arrow" is="paper-icon-button-light"
aria-label="$i18n{siteSettingsUsbDevices}"></button>
</div>
- <div class="settings-box" data-route="SITE_SETTINGS_PDF_DOCUMENTS"
- on-tap="onTapNavigate_" actionable>
+ <div id="pdf-documents" class="settings-box"
+ data-route="SITE_SETTINGS_PDF_DOCUMENTS" on-tap="onTapNavigate_"
+ actionable>
<iron-icon icon="settings:pdf"></iron-icon>
<div class="middle">$i18n{siteSettingsPdfDocuments}</div>
<button class="subpage-arrow" is="paper-icon-button-light"
aria-label="$i18n{siteSettingsPdfDocuments}"></button>
</div>
- <div class="settings-box" data-route="SITE_SETTINGS_PROTECTED_CONTENT"
- on-tap="onTapNavigate_" actionable>
+ <div id="protected-content" class="settings-box"
+ data-route="SITE_SETTINGS_PROTECTED_CONTENT" on-tap="onTapNavigate_"
+ actionable>
<iron-icon icon="settings:security"></iron-icon>
<div class="middle">$i18n{siteSettingsProtectedContent}</div>
<button class="subpage-arrow" is="paper-icon-button-light"

Powered by Google App Engine
This is Rietveld 408576698