Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: gm/gm_expectations.h

Issue 281303003: Generate gm/Android.mk, minus JSON. (Closed) Base URL: https://skia.googlesource.com/skia.git@baseline_gm
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Android.mk ('K') | « gm/Android.mk ('k') | gm/gm_expectations.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gm/gm_expectations.h
diff --git a/gm/gm_expectations.h b/gm/gm_expectations.h
index 70921273380ab8b13cf609ff739cdb466fbd322b..170a0a6e5ead9c3c6acedb39c4e9e3354041606b 100644
--- a/gm/gm_expectations.h
+++ b/gm/gm_expectations.h
@@ -22,12 +22,15 @@
namespace skiagm {
+// FIXME (scroggo): JSON is disabled in Android framework until we solve
+// skbug.com/2448
+#ifndef SK_BUILD_FOR_ANDROID_FRAMEWORK
Json::Value CreateJsonTree(Json::Value expectedResults,
Json::Value actualResultsFailed,
Json::Value actualResultsFailureIgnored,
Json::Value actualResultsNoComparison,
Json::Value actualResultsSucceeded);
-
+#endif
/**
* The digest of a GM test result.
*
@@ -41,12 +44,16 @@ namespace skiagm {
*/
explicit GmResultDigest(const SkBitmap &bitmap);
+// FIXME (scroggo): JSON is disabled in Android framework until we solve
+// skbug.com/2448
+#ifndef SK_BUILD_FOR_ANDROID_FRAMEWORK
/**
* Create a ResultDigest representing an allowed result
* checksum within JSON expectations file, in the form
* ["bitmap-64bitMD5", 12345].
*/
explicit GmResultDigest(const Json::Value &jsonTypeValuePair);
+#endif
/**
* Returns true if this GmResultDigest was fully and successfully
@@ -60,11 +67,15 @@ namespace skiagm {
*/
bool equals(const GmResultDigest &other) const;
+// FIXME (scroggo): JSON is disabled in Android framework until we solve
+// skbug.com/2448
+#ifndef SK_BUILD_FOR_ANDROID_FRAMEWORK
/**
* Returns a JSON type/value pair representing this result,
* such as ["bitmap-64bitMD5", 12345].
*/
Json::Value asJsonTypeValuePair() const;
+#endif
/**
* Returns the hashtype, such as "bitmap-64bitMD5", as an SkString.
@@ -113,6 +124,9 @@ namespace skiagm {
*/
explicit Expectations(const BitmapAndDigest& bitmapAndDigest);
+// FIXME (scroggo): JSON is disabled in Android framework until we solve
+// skbug.com/2448
+#ifndef SK_BUILD_FOR_ANDROID_FRAMEWORK
/**
* Create Expectations from a JSON element as found within the
* kJsonKey_ExpectedResults section.
@@ -121,6 +135,7 @@ namespace skiagm {
* don't have any expectations.
*/
explicit Expectations(Json::Value jsonElement);
+#endif
/**
* Returns true iff we want to ignore failed expectations.
@@ -154,10 +169,14 @@ namespace skiagm {
return (SkBitmap::kNo_Config == fBitmap.config()) ? NULL : &fBitmap;
}
+// FIXME (scroggo): JSON is disabled in Android framework until we solve
+// skbug.com/2448
+#ifndef SK_BUILD_FOR_ANDROID_FRAMEWORK
/**
* Return a JSON representation of the expectations.
*/
Json::Value asJsonValue() const;
+#endif
private:
const static bool kDefaultIgnoreFailure = false;
@@ -200,6 +219,9 @@ namespace skiagm {
const SkString fRootDir;
};
+// FIXME (scroggo): JSON is disabled in Android framework until we solve
+// skbug.com/2448
+#ifndef SK_BUILD_FOR_ANDROID_FRAMEWORK
/**
* Return Expectations based on JSON summary file.
*/
@@ -227,6 +249,7 @@ namespace skiagm {
Json::Value fJsonRoot;
Json::Value fJsonExpectedResults;
};
+#endif // SK_BUILD_FOR_ANDROID_FRAMEWORK
}
#endif
« Android.mk ('K') | « gm/Android.mk ('k') | gm/gm_expectations.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698