[Cronet] Move initialization to a new thread rather than the UI thread.

net/proxy/proxy_config_service_android_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/proxy/proxy_config_service_android.h"
 
 #include <map>
 #include <memory>
 #include <string>
 
 #include "base/bind.h"
 #include "base/compiler_specific.h"
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
+#include "jni/AndroidProxyConfigServiceTestUtil_jni.h"
 #include "net/proxy/proxy_config.h"
 #include "net/proxy/proxy_info.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace net {
 
 namespace {
 
 class TestObserver : public ProxyConfigService::Observer {
  public:
@@ skipping 13 matching lines @@
 
   const ProxyConfig& config() const {
     return config_;
   }
 
  private:
   ProxyConfig config_;
   ProxyConfigService::ConfigAvailability availability_;
 };
 
+// Helper class that simply prepares Java's Looper on construction.
+class JavaLooperPreparer {
+ public:
+  JavaLooperPreparer() {
+    Java_AndroidProxyConfigServiceTestUtil_prepareLooper(
+        base::android::AttachCurrentThread());
+  }
+};
+
 }  // namespace
 
 typedef std::map<std::string, std::string> StringMap;
 
 class ProxyConfigServiceAndroidTestBase : public testing::Test {
  protected:
   // Note that the current thread's message loop is initialized by the test
   // suite (see net/test/net_test_suite.cc).
   ProxyConfigServiceAndroidTestBase(const StringMap& initial_configuration)
       : configuration_(initial_configuration),
         message_loop_(base::MessageLoop::current()),
+        // Prepare Java's Looper before constructing |service_| as it creates
+        // ProxyChangeListener which requires a Looper.
+        java_looper_preparer_(),

[xunjieli, 2017/04/13 18:44:54]

hmm.. I guess this isn't safe to omit? I'd assume the compiler initializes
|java_looper_preparer_| before |service_| because that's the order specified
below.

[pauljensen, 2017/05/01 15:35:53]

You're right, I think I put it here so the comment would precede the |service_|
initializer call.  I've now moved the comment to java_looper_preparer_
declaration.

         service_(message_loop_->task_runner(),
                  message_loop_->task_runner(),
                  base::Bind(&ProxyConfigServiceAndroidTestBase::GetProperty,
                             base::Unretained(this))) {}
 
   ~ProxyConfigServiceAndroidTestBase() override {}
 
   // testing::Test:
   void SetUp() override {
     base::RunLoop().RunUntilIdle();
@@ skipping 28 matching lines @@
     availability = service_.GetLatestProxyConfig(&proxy_config);
     EXPECT_EQ(ProxyConfigService::CONFIG_VALID, availability);
     ProxyInfo proxy_info;
     proxy_config.proxy_rules().Apply(GURL(url), &proxy_info);
     EXPECT_EQ(expected, proxy_info.ToPacString());
   }
 
   StringMap configuration_;
   TestObserver observer_;
   base::MessageLoop* const message_loop_;
+  JavaLooperPreparer java_looper_preparer_;
   ProxyConfigServiceAndroid service_;
 };
 
 class ProxyConfigServiceAndroidTest : public ProxyConfigServiceAndroidTestBase {
  public:
   ProxyConfigServiceAndroidTest()
       : ProxyConfigServiceAndroidTestBase(StringMap()) {}
 };
 
 class ProxyConfigServiceAndroidWithInitialConfigTest
@@ skipping 226 matching lines @@
 TEST_F(ProxyConfigServiceAndroidTest, HttpProxySupercedesSocks) {
   // SOCKS proxy is ignored if default HTTP proxy defined.
   AddProperty("proxyHost", "defaultproxy.com");
   AddProperty("socksProxyHost", "socksproxy.com");
   AddProperty("socksProxyPort", "9000");
   ProxySettingsChanged();
   TestMapping("http://example.com/", "PROXY defaultproxy.com:80");
 }
 
 }  // namespace net