chrome/browser/ui/webui/voice_search_ui.cc - Issue 2812953002: Stop passing raw pointers to base::Value API in c/b/ui

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/voice_search_ui.cc

Issue 2812953002: Stop passing raw pointers to base::Value API in c/b/ui (Closed)

Patch Set: No ListValue::SetDouble Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/voice_search_ui.cc

diff --git a/chrome/browser/ui/webui/voice_search_ui.cc b/chrome/browser/ui/webui/voice_search_ui.cc

index 5eba13c176c1a78da352bfa6d0b19eb823aec903..6e3882b69491b42a5c3f8c8a3d4b22c47b40764f 100644

--- a/chrome/browser/ui/webui/voice_search_ui.cc

+++ b/chrome/browser/ui/webui/voice_search_ui.cc

@@ -164,7 +164,7 @@ class VoiceSearchDomHandler : public WebUIMessageHandler {

DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

DCHECK(info);

base::DictionaryValue voiceSearchInfo;

- voiceSearchInfo.Set("voiceSearchInfo", info.release());

+ voiceSearchInfo.Set("voiceSearchInfo", std::move(info));

web_ui()->CallJavascriptFunctionUnsafe("returnVoiceSearchInfo",

voiceSearchInfo);

}