Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Unified Diff: chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc

Issue 2812953002: Stop passing raw pointers to base::Value API in c/b/ui (Closed)
Patch Set: No ListValue::SetDouble Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
diff --git a/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc b/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
index 8a8b009155a903623419459db0c7c24f9b3d7dd0..9c20c7908c6ca2a862ef10db7a7ae1e78044128d 100644
--- a/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
+++ b/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
@@ -138,16 +138,15 @@ void CupsPrintersHandler::HandleGetCupsPrintersList(
std::vector<std::unique_ptr<Printer>> printers =
PrintersManagerFactory::GetForBrowserContext(profile_)->GetPrinters();
- base::ListValue* printers_list = new base::ListValue;
+ auto printers_list = base::MakeUnique<base::ListValue>();
for (const std::unique_ptr<Printer>& printer : printers) {
std::unique_ptr<base::DictionaryValue> printer_info =
GetPrinterInfo(*printer.get());
printers_list->Append(std::move(printer_info));
}
- std::unique_ptr<base::DictionaryValue> response =
- base::MakeUnique<base::DictionaryValue>();
- response->Set("printerList", printers_list);
+ auto response = base::MakeUnique<base::DictionaryValue>();
+ response->Set("printerList", std::move(printers_list));
ResolveJavascriptCallback(base::Value(callback_id), *response);
}

Powered by Google App Engine
This is Rietveld 408576698