Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4632)

Unified Diff: chrome/browser/ui/webui/options/language_options_handler.h

Issue 2812953002: Stop passing raw pointers to base::Value API in c/b/ui (Closed)
Patch Set: No ListValue::SetDouble Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/language_options_handler.h
diff --git a/chrome/browser/ui/webui/options/language_options_handler.h b/chrome/browser/ui/webui/options/language_options_handler.h
index 41725792ee0ec1bcd0bbc6b2b15f7ea3267ec678..93943cd67447bf8a8250a267e5866d2784ef7b6e 100644
--- a/chrome/browser/ui/webui/options/language_options_handler.h
+++ b/chrome/browser/ui/webui/options/language_options_handler.h
@@ -5,9 +5,15 @@
#ifndef CHROME_BROWSER_UI_WEBUI_OPTIONS_LANGUAGE_OPTIONS_HANDLER_H_
#define CHROME_BROWSER_UI_WEBUI_OPTIONS_LANGUAGE_OPTIONS_HANDLER_H_
+#include <memory>
+
#include "base/macros.h"
#include "chrome/browser/ui/webui/options/language_options_handler_common.h"
+namespace base {
+class ListValue;
+}
+
namespace options {
// Language options UI page handler for non-Chrome OS platforms. For Chrome OS,
@@ -29,7 +35,7 @@ class LanguageOptionsHandler : public LanguageOptionsHandlerCommon {
// The return value will look like:
// [{'code': 'fi', 'displayName': 'Finnish', 'nativeDisplayName': 'suomi'},
// ...]
- static base::ListValue* GetLanguageList();
+ static std::unique_ptr<base::ListValue> GetLanguageList();
private:
// LanguageOptionsHandlerCommon implementation.

Powered by Google App Engine
This is Rietveld 408576698