chrome/browser/ui/webui/nacl_ui.cc - Issue 2812953002: Stop passing raw pointers to base::Value API in c/b/ui

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/nacl_ui.cc

Issue 2812953002: Stop passing raw pointers to base::Value API in c/b/ui (Closed)

Patch Set: No ListValue::SetDouble Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/nacl_ui.cc

diff --git a/chrome/browser/ui/webui/nacl_ui.cc b/chrome/browser/ui/webui/nacl_ui.cc

index 78b376885ec6f1f9d0a7ada28cdd6003917a46e0..276468acd5dc86b3f8c6cf1eef57aa64624e9fc2 100644

--- a/chrome/browser/ui/webui/nacl_ui.cc

+++ b/chrome/browser/ui/webui/nacl_ui.cc

@@ -320,7 +320,7 @@ void NaClDomHandler::PopulatePageInformation(base::DictionaryValue* naclInfo) {

// Display information relevant to NaCl (non-portable.

AddNaClInfo(list.get());

// naclInfo will take ownership of list, and clean it up on destruction.

- naclInfo->Set("naclInfo", list.release());

+ naclInfo->Set("naclInfo", std::move(list));

}

void NaClDomHandler::DidCheckPathAndVersion(const std::string* version,