chrome/browser/ui/webui/chromeos/set_time_ui.cc - Issue 2812953002: Stop passing raw pointers to base::Value API in c/b/ui

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/chromeos/set_time_ui.cc

Issue 2812953002: Stop passing raw pointers to base::Value API in c/b/ui (Closed)

Patch Set: No ListValue::SetDouble Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/chromeos/set_time_ui.cc

diff --git a/chrome/browser/ui/webui/chromeos/set_time_ui.cc b/chrome/browser/ui/webui/chromeos/set_time_ui.cc

index 154c9ed845aad083d6c576cdfb947742ca7b3938..98871678f7e8a217b48ccf01af37e73d426bafec 100644

--- a/chrome/browser/ui/webui/chromeos/set_time_ui.cc

+++ b/chrome/browser/ui/webui/chromeos/set_time_ui.cc

@@ -118,7 +118,7 @@ SetTimeUI::SetTimeUI(content::WebUI* web_ui) : WebDialogUI(web_ui) {

source->AddLocalizedString("timeLabel", IDS_SET_TIME_TIME_LABEL);

base::DictionaryValue values;

- values.Set("timezoneList", chromeos::system::GetTimezoneList().release());

+ values.Set("timezoneList", chromeos::system::GetTimezoneList());

// If we are not logged in, we need to show the time zone dropdown.

// Otherwise, we can leave |currentTimezoneId| blank.