Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3680)

Unified Diff: chrome/browser/ui/webui/chromeos/login/network_dropdown.cc

Issue 2812953002: Stop passing raw pointers to base::Value API in c/b/ui (Closed)
Patch Set: No ListValue::SetDouble Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chromeos/login/network_dropdown.cc
diff --git a/chrome/browser/ui/webui/chromeos/login/network_dropdown.cc b/chrome/browser/ui/webui/chromeos/login/network_dropdown.cc
index 231dc669e2935d3fccc68bec8930eddc7178dfcb..deb66892b6e0e4c47eb50259f005e419c7fc266a 100644
--- a/chrome/browser/ui/webui/chromeos/login/network_dropdown.cc
+++ b/chrome/browser/ui/webui/chromeos/login/network_dropdown.cc
@@ -48,7 +48,7 @@ class NetworkMenuWebUI : public NetworkMenu {
private:
// Converts menu model into the ListValue, ready for passing to WebUI.
- base::ListValue* ConvertMenuModel(ui::MenuModel* model);
+ std::unique_ptr<base::ListValue> ConvertMenuModel(ui::MenuModel* model);
// WebUI where network menu is located.
content::WebUI* web_ui_;
@@ -81,8 +81,9 @@ void NetworkMenuWebUI::OnItemChosen(int id) {
model->ActivatedAt(index);
}
-base::ListValue* NetworkMenuWebUI::ConvertMenuModel(ui::MenuModel* model) {
- base::ListValue* list = new base::ListValue();
+std::unique_ptr<base::ListValue> NetworkMenuWebUI::ConvertMenuModel(
+ ui::MenuModel* model) {
+ auto list = base::MakeUnique<base::ListValue>();
for (int i = 0; i < model->GetItemCount(); ++i) {
ui::MenuModel::ItemType type = model->GetTypeAt(i);
int id;

Powered by Google App Engine
This is Rietveld 408576698