chrome/browser/ui/app_list/search/common/webservice_cache.h - Issue 2812953002: Stop passing raw pointers to base::Value API in c/b/ui

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/search/common/webservice_cache.h

Issue 2812953002: Stop passing raw pointers to base::Value API in c/b/ui (Closed)

Patch Set: No ListValue::SetDouble Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/app_list/search/common/webservice_cache.h

diff --git a/chrome/browser/ui/app_list/search/common/webservice_cache.h b/chrome/browser/ui/app_list/search/common/webservice_cache.h

index d9f67ca541016b4497682e7f917977ae421904ca..425c38a4da73c23c7c1d4ede7fa0db9f3b3608f1 100644

--- a/chrome/browser/ui/app_list/search/common/webservice_cache.h

+++ b/chrome/browser/ui/app_list/search/common/webservice_cache.h

@@ -88,7 +88,8 @@ class WebserviceCache : public KeyedService,

// Returns a dictionary value for a given payload. The returned dictionary

// will be owned by the data_store_ cached_dict, and freed on the destruction

// of our dictionary datastore.

- base::DictionaryValue* DictFromPayload(const Payload& payload);

+ std::unique_ptr<base::DictionaryValue> DictFromPayload(

+ const Payload& payload);

// Trims our MRU cache, making sure that any element that is removed is also

// removed from the dictionary data store.