Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3177)

Unified Diff: chrome/browser/ui/webui/options/language_options_handler_common.h

Issue 2812953002: Stop passing raw pointers to base::Value API in c/b/ui (Closed)
Patch Set: Rebased Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/language_options_handler_common.h
diff --git a/chrome/browser/ui/webui/options/language_options_handler_common.h b/chrome/browser/ui/webui/options/language_options_handler_common.h
index 1b94a67d3c55d0cdbaa740c2f21fcf62d9150ba0..18e3355757630386b24c888ad202b5d5eddee044 100644
--- a/chrome/browser/ui/webui/options/language_options_handler_common.h
+++ b/chrome/browser/ui/webui/options/language_options_handler_common.h
@@ -5,6 +5,8 @@
#ifndef CHROME_BROWSER_UI_WEBUI_OPTIONS_LANGUAGE_OPTIONS_HANDLER_COMMON_H_
#define CHROME_BROWSER_UI_WEBUI_OPTIONS_LANGUAGE_OPTIONS_HANDLER_COMMON_H_
+#include <memory>
+
#include "base/macros.h"
#include "base/memory/weak_ptr.h"
#include "chrome/browser/spellchecker/spellcheck_hunspell_dictionary.h"
@@ -49,7 +51,7 @@ class LanguageOptionsHandlerCommon
//
// Note that true in values does not mean anything. We just use the
// dictionary as a set.
- static base::DictionaryValue* GetUILanguageCodeSet();
+ static std::unique_ptr<base::DictionaryValue> GetUILanguageCodeSet();
// Gets the set of language codes that can be used for spellchecking.
// The return value will look like:
@@ -57,7 +59,7 @@ class LanguageOptionsHandlerCommon
//
// Note that true in values does not mean anything. We just use the
// dictionary as a set.
- static base::DictionaryValue* GetSpellCheckLanguageCodeSet();
+ static std::unique_ptr<base::DictionaryValue> GetSpellCheckLanguageCodeSet();
private:
// Sets the application locale.

Powered by Google App Engine
This is Rietveld 408576698