chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.h - Issue 2812953002: Stop passing raw pointers to base::Value API in c/b/ui

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.h

Issue 2812953002: Stop passing raw pointers to base::Value API in c/b/ui (Closed)

Patch Set: Rebased Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/ntp/app_launcher_handler.cc ('K') | « chrome/browser/ui/webui/options/certificate_manager_handler.cc ('k') | chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc » ('j') | chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.h

diff --git a/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.h b/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.h

index 2381d54d323d6c30122326a8c5b62633ec05e9c4..5d1d11923d23471bc984c4708db3eac74caf58dc 100644

--- a/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.h

+++ b/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.h

@@ -27,14 +27,14 @@ class CoreChromeOSOptionsHandler : public ::options::CoreOptionsHandler,

// ::CoreOptionsHandler overrides

void RegisterMessages() override;

- base::Value* FetchPref(const std::string& pref_name) override;

+ std::unique_ptr<base::Value> FetchPref(const std::string& pref_name) override;

void InitializeHandler() override;

void ObservePref(const std::string& pref_name) override;

void SetPref(const std::string& pref_name,

const base::Value* value,

const std::string& metric) override;

void StopObservingPref(const std::string& path) override;

- base::Value* CreateValueForPref(

+ std::unique_ptr<base::Value> CreateValueForPref(

const std::string& pref_name,

const std::string& controlling_pref_name) override;