Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: chrome/browser/ui/webui/options/autofill_options_handler.cc

Issue 2812953002: Stop passing raw pointers to base::Value API in c/b/ui (Closed)
Patch Set: Rebased Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/autofill_options_handler.cc
diff --git a/chrome/browser/ui/webui/options/autofill_options_handler.cc b/chrome/browser/ui/webui/options/autofill_options_handler.cc
index b3362a2a03576ccd9e338faed1f628d8a20b4914..f4480a23c6922e5e03f9f107b2f4239641aca3d2 100644
--- a/chrome/browser/ui/webui/options/autofill_options_handler.cc
+++ b/chrome/browser/ui/webui/options/autofill_options_handler.cc
@@ -290,7 +290,7 @@ void AutofillOptionsHandler::LoadAddressEditorComponents(
autofill::GetAddressComponents(country_code,
g_browser_process->GetApplicationLocale(),
components.get(), &language_code);
- input.Set(kComponents, components.release());
+ input.Set(kComponents, std::move(components));
input.SetString(kLanguageCode, language_code);
web_ui()->CallJavascriptFunctionUnsafe(
@@ -501,7 +501,7 @@ void AutofillOptionsHandler::AutofillProfileToDictionary(
autofill::GetAddressComponents(
base::UTF16ToUTF8(profile.GetRawInfo(autofill::ADDRESS_HOME_COUNTRY)),
profile.language_code(), components.get(), nullptr);
- address->Set(kComponents, components.release());
+ address->Set(kComponents, std::move(components));
}
} // namespace options

Powered by Google App Engine
This is Rietveld 408576698