Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3079)

Unified Diff: chrome/browser/ui/webui/nacl_ui.cc

Issue 2812953002: Stop passing raw pointers to base::Value API in c/b/ui (Closed)
Patch Set: Rebased Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/nacl_ui.cc
diff --git a/chrome/browser/ui/webui/nacl_ui.cc b/chrome/browser/ui/webui/nacl_ui.cc
index 78b376885ec6f1f9d0a7ada28cdd6003917a46e0..276468acd5dc86b3f8c6cf1eef57aa64624e9fc2 100644
--- a/chrome/browser/ui/webui/nacl_ui.cc
+++ b/chrome/browser/ui/webui/nacl_ui.cc
@@ -320,7 +320,7 @@ void NaClDomHandler::PopulatePageInformation(base::DictionaryValue* naclInfo) {
// Display information relevant to NaCl (non-portable.
AddNaClInfo(list.get());
// naclInfo will take ownership of list, and clean it up on destruction.
- naclInfo->Set("naclInfo", list.release());
+ naclInfo->Set("naclInfo", std::move(list));
}
void NaClDomHandler::DidCheckPathAndVersion(const std::string* version,

Powered by Google App Engine
This is Rietveld 408576698