Stop passing raw pointers to base::Value API in c/b/ui

chrome/browser/ui/webui/signin/sync_confirmation_handler_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/signin/sync_confirmation_handler.h"
 
+#include "base/memory/ptr_util.h"
 #include "base/test/user_action_tester.h"
 #include "base/values.h"
 #include "chrome/browser/profiles/profile_avatar_icon_util.h"
 #include "chrome/browser/signin/account_fetcher_service_factory.h"
 #include "chrome/browser/signin/account_tracker_service_factory.h"
 #include "chrome/browser/signin/fake_account_fetcher_service_builder.h"
 #include "chrome/browser/signin/fake_signin_manager_builder.h"
 #include "chrome/browser/signin/signin_manager_factory.h"
 #include "chrome/browser/sync/profile_sync_service_factory.h"
 #include "chrome/browser/ui/browser_commands.h"
@@ skipping 165 matching lines @@
       "gaia",
       "foo@example.com",
       "gaia",
       "",
       "full_name",
       "given_name",
       "locale",
       "http://picture.example.com/picture.jpg");
 
   base::ListValue args;
-  args.Set(0, new base::Value(kDefaultDialogHeight));
+  args.Set(0, base::MakeUnique<base::Value>(kDefaultDialogHeight));
   handler()->HandleInitializedWithSize(&args);
   EXPECT_EQ(2U, web_ui()->call_data().size());
 
   // When the primary account is ready, setUserImageURL happens before
   // clearFocus since the image URL is known before showing the dialog.
   EXPECT_EQ("sync.confirmation.setUserImageURL",
             web_ui()->call_data()[0]->function_name());
   EXPECT_TRUE(
       web_ui()->call_data()[0]->arg1()->IsType(base::Value::Type::STRING));
   std::string passed_picture_url;
   EXPECT_TRUE(
       web_ui()->call_data()[0]->arg1()->GetAsString(&passed_picture_url));
 
   EXPECT_EQ("sync.confirmation.clearFocus",
             web_ui()->call_data()[1]->function_name());
 
   std::string original_picture_url =
       AccountTrackerServiceFactory::GetForProfile(profile())->
           GetAccountInfo("gaia").picture_url;
   GURL picture_url_with_size;
   EXPECT_TRUE(profiles::GetImageURLWithThumbnailSize(GURL(original_picture_url),
                                                      kExpectedProfileImageSize,
                                                      &picture_url_with_size));
   EXPECT_EQ(picture_url_with_size.spec(), passed_picture_url);
 }
 
 TEST_F(SyncConfirmationHandlerTest, TestSetImageIfPrimaryAccountReadyLater) {
   base::ListValue args;
-  args.Set(0, new base::Value(kDefaultDialogHeight));
+  args.Set(0, base::MakeUnique<base::Value>(kDefaultDialogHeight));
   handler()->HandleInitializedWithSize(&args);
   EXPECT_EQ(2U, web_ui()->call_data().size());
 
   account_fetcher_service()->FakeUserInfoFetchSuccess(
       "gaia",
       "foo@example.com",
       "gaia",
       "",
       "full_name",
       "given_name",
@@ skipping 31 matching lines @@
   GURL picture_url_with_size;
   EXPECT_TRUE(profiles::GetImageURLWithThumbnailSize(GURL(original_picture_url),
                                                      kExpectedProfileImageSize,
                                                      &picture_url_with_size));
   EXPECT_EQ(picture_url_with_size.spec(), passed_picture_url);
 }
 
 TEST_F(SyncConfirmationHandlerTest,
        TestSetImageIgnoredIfSecondaryAccountUpdated) {
   base::ListValue args;
-  args.Set(0, new base::Value(kDefaultDialogHeight));
+  args.Set(0, base::MakeUnique<base::Value>(kDefaultDialogHeight));
   handler()->HandleInitializedWithSize(&args);
   EXPECT_EQ(2U, web_ui()->call_data().size());
 
   AccountTrackerServiceFactory::GetForProfile(profile())->SeedAccountInfo(
       "bar_gaia", "bar@example.com");
   account_fetcher_service()->FakeUserInfoFetchSuccess(
       "bar_gaia", "bar@example.com", "bar_gaia", "", "bar_full_name",
       "bar_given_name", "bar_locale",
       "http://picture.example.com/bar_picture.jpg");
 
@@ skipping 62 matching lines @@
   EXPECT_FALSE(sync()->IsFirstSetupInProgress());
   EXPECT_FALSE(sync()->IsFirstSetupComplete());
   EXPECT_TRUE(
       SigninManagerFactory::GetForProfile(profile())->IsAuthenticated());
   EXPECT_EQ(0, user_action_tester()->GetActionCount("Signin_Undo_Signin"));
   EXPECT_EQ(0, user_action_tester()->GetActionCount(
                    "Signin_Signin_WithDefaultSyncSettings"));
   EXPECT_EQ(1, user_action_tester()->GetActionCount(
                    "Signin_Signin_WithAdvancedSyncSettings"));
 }