chrome/browser/ui/webui/options/reset_profile_settings_handler.cc - Issue 2812953002: Stop passing raw pointers to base::Value API in c/b/ui

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/webui/options/reset_profile_settings_handler.cc

Issue 2812953002: Stop passing raw pointers to base::Value API in c/b/ui (Closed)

Patch Set: No ListValue::SetDouble Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/ui/webui/options/language_options_handler_common.cc ('k') | chrome/browser/ui/webui/options/search_engine_manager_handler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/webui/options/reset_profile_settings_handler.h"	5 #include "chrome/browser/ui/webui/options/reset_profile_settings_handler.h"

6	6

7 #include <utility>	7 #include <utility>

8	8

9 #include "base/bind.h"	9 #include "base/bind.h"

10 #include "base/bind_helpers.h"	10 #include "base/bind_helpers.h"

(...skipping 243 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
254 "ProfileReset.ResetRequestOrigin", request_origin,	254 "ProfileReset.ResetRequestOrigin", request_origin,

255 reset_report::ChromeResetReport::ResetRequestOrigin_MAX + 1);	255 reset_report::ChromeResetReport::ResetRequestOrigin_MAX + 1);

256 }	256 }

257	257

258 void ResetProfileSettingsHandler::UpdateFeedbackUI() {	258 void ResetProfileSettingsHandler::UpdateFeedbackUI() {

259 if (!setting_snapshot_)	259 if (!setting_snapshot_)

260 return;	260 return;

261 std::unique_ptr<base::ListValue> list = GetReadableFeedbackForSnapshot(	261 std::unique_ptr<base::ListValue> list = GetReadableFeedbackForSnapshot(

262 Profile::FromWebUI(web_ui()), *setting_snapshot_);	262 Profile::FromWebUI(web_ui()), *setting_snapshot_);

263 base::DictionaryValue feedback_info;	263 base::DictionaryValue feedback_info;

264 feedback_info.Set("feedbackInfo", list.release());	264 feedback_info.Set("feedbackInfo", std::move(list));

265 web_ui()->CallJavascriptFunctionUnsafe(	265 web_ui()->CallJavascriptFunctionUnsafe(

266 "ResetProfileSettingsOverlay.setFeedbackInfo", feedback_info);	266 "ResetProfileSettingsOverlay.setFeedbackInfo", feedback_info);

267 }	267 }

268	268

269 } // namespace options	269 } // namespace options

OLD	NEW