Stop passing raw pointers to base::Value API in c/b/ui

chrome/browser/ui/webui/instant_ui.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/instant_ui.h"
 
 #include <stdint.h>
 
 #include <memory>
 #include <utility>
 
 #include "base/bind.h"
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/time/time.h"

[jdoerrie, 2017/04/13 09:08:51]

#include "base/values.h"

[vabr (Chromium), 2017/04/13 12:03:14]

Done.

 #include "build/build_config.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/browser_instant_controller.h"
 #include "chrome/browser/ui/search/instant_controller.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/grit/browser_resources.h"
 #include "components/pref_registry/pref_registry_syncable.h"
 #include "components/prefs/pref_service.h"
@@ skipping 106 matching lines @@
     return;
   Browser* browser = chrome::FindBrowserWithWebContents(
       web_ui()->GetWebContents());
   if (!browser || !browser->instant_controller())
     return;
 
   InstantController* instant = browser->instant_controller()->instant();
   const std::list<DebugEvent>& events = instant->debug_events();
 
   base::DictionaryValue data;
-  base::ListValue* entries = new base::ListValue();
+  auto entries = base::MakeUnique<base::ListValue>();
   for (std::list<DebugEvent>::const_iterator it = events.begin();
        it != events.end(); ++it) {
     std::unique_ptr<base::DictionaryValue> entry(new base::DictionaryValue());
     entry->SetString("time", FormatTime(it->first));
     entry->SetString("text", it->second);
     entries->Append(std::move(entry));
   }
-  data.Set("entries", entries);
+  data.Set("entries", std::move(entries));
 
   web_ui()->CallJavascriptFunctionUnsafe("instantConfig.getDebugInfoResult",
                                          data);
 #endif
 }
 
 void InstantUIMessageHandler::ClearDebugInfo(const base::ListValue* args) {
 #if !defined(OS_ANDROID)
   if (!web_ui()->GetWebContents())
     return;
@@ skipping 18 matching lines @@
   Profile* profile = Profile::FromWebUI(web_ui);
   content::WebUIDataSource::Add(profile, CreateInstantHTMLSource());
 }
 
 // static
 void InstantUI::RegisterProfilePrefs(
     user_prefs::PrefRegistrySyncable* registry) {
   registry->RegisterStringPref(prefs::kInstantUIZeroSuggestUrlPrefix,
                                std::string());
 }