Stop passing raw pointers to base::Value API in c/b/ui

chrome/browser/ui/webui/cookies_tree_model_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/cookies_tree_model_util.h"
 
 #include <memory>
 #include <utility>
 #include <vector>
 
 #include "base/i18n/time_formatting.h"
+#include "base/memory/ptr_util.h"
 #include "base/stl_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
 #include "base/values.h"
 #include "build/build_config.h"
 #include "chrome/browser/browsing_data/cookies_tree_model.h"
 #include "chrome/grit/generated_resources.h"
 #include "content/public/browser/cache_storage_context.h"
 #include "content/public/browser/indexed_db_context.h"
@@ skipping 226 matching lines @@
     }
     case CookieTreeNode::DetailedInfo::TYPE_SERVICE_WORKER: {
       dict->SetString(kKeyType, "service_worker");
 
       const content::ServiceWorkerUsageInfo& service_worker_info =
           *node.GetDetailedInfo().service_worker_info;
 
       dict->SetString(kKeyOrigin, service_worker_info.origin.spec());
       dict->SetString(kKeySize,
                       ui::FormatBytes(service_worker_info.total_size_bytes));
-      base::ListValue* scopes = new base::ListValue;
+      auto scopes = base::MakeUnique<base::ListValue>();
       for (std::vector<GURL>::const_iterator it =
                service_worker_info.scopes.begin();
            it != service_worker_info.scopes.end();
            ++it) {
         scopes->AppendString(it->spec());
       }
-      dict->Set(kKeyScopes, scopes);
+      dict->Set(kKeyScopes, std::move(scopes));
       break;
     }
     case CookieTreeNode::DetailedInfo::TYPE_CACHE_STORAGE: {
       dict->SetString(kKeyType, "cache_storage");
 
       const content::CacheStorageUsageInfo& cache_storage_info =
           *node.GetDetailedInfo().cache_storage_info;
 
       dict->SetString(kKeyOrigin, cache_storage_info.origin.spec());
       dict->SetString(kKeySize,
@@ skipping 22 matching lines @@
       break;
     }
     default:
       break;
   }
 
 #if BUILDFLAG(ENABLE_EXTENSIONS)
   const extensions::ExtensionSet* protecting_apps =
       node.GetModel()->ExtensionsProtectingNode(node);
   if (protecting_apps && !protecting_apps->is_empty()) {
-    base::ListValue* app_infos = new base::ListValue;
+    auto app_infos = base::MakeUnique<base::ListValue>();
     for (extensions::ExtensionSet::const_iterator it = protecting_apps->begin();
          it != protecting_apps->end(); ++it) {
       std::unique_ptr<base::DictionaryValue> app_info(
           new base::DictionaryValue());
       app_info->SetString(kKeyId, (*it)->id());
       app_info->SetString(kKeyName, (*it)->name());
       app_infos->Append(std::move(app_info));
     }
-    dict->Set(kKeyAppsProtectingThis, app_infos);
+    dict->Set(kKeyAppsProtectingThis, std::move(app_infos));
   }
 #endif
 
   return true;
 }
 
 void CookiesTreeModelUtil::GetChildNodeDetails(const CookieTreeNode* parent,
                                                int start,
                                                int count,
                                                bool include_quota_nodes,
@@ skipping 63 matching lines @@
   // lookup for O(1) space, but it could be further improved to O(1) lookup if
   // desired (by trading O(n) space for the time improvement).
   int site_count = root->child_count();
   for (int i = 0; i < site_count; ++i) {
     const CookieTreeNode* child = root->GetChild(i);
     if (title == child->GetTitle())
       return child;
   }
   return nullptr;
 }