Stop passing raw pointers to base::Value API in c/b/ui

chrome/browser/ui/webui/options/core_options_handler.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBUI_OPTIONS_CORE_OPTIONS_HANDLER_H_
 #define CHROME_BROWSER_UI_WEBUI_OPTIONS_CORE_OPTIONS_HANDLER_H_
 
 #include <map>
+#include <memory>
 #include <string>
 
 #include "base/callback.h"
 #include "base/macros.h"
 #include "base/values.h"
 #include "chrome/browser/plugins/plugin_status_pref_setter.h"
 #include "chrome/browser/ui/webui/options/options_ui.h"
 #include "components/prefs/pref_change_registrar.h"
 #include "components/prefs/pref_service.h"
 
@@ skipping 19 matching lines @@
     handlers_host_ = handlers_host;
   }
 
   // Adds localized strings to |localized_strings|.
   static void GetStaticLocalizedValues(
       base::DictionaryValue* localized_strings);
 
  protected:
   // Fetches a pref value of given |pref_name|.
   // Note that caller owns the returned Value.
-  virtual base::Value* FetchPref(const std::string& pref_name);
+  virtual std::unique_ptr<base::Value> FetchPref(const std::string& pref_name);
 
   // Observes a pref of given |pref_name|.
   virtual void ObservePref(const std::string& pref_name);
 
   // Stops observing given preference identified by |pref_name|.
   virtual void StopObservingPref(const std::string& pref_name);
 
   // Sets a pref |value| to given |pref_name|.
   virtual void SetPref(const std::string& pref_name,
                        const base::Value* value,
@@ skipping 22 matching lines @@
 
   // Calls JS callbacks to report a change in the value of the |name|
   // preference. |value| is the new value for |name|.  Called from
   // Notify*Changed methods to fire off the notifications.
   void DispatchPrefChangeNotification(const std::string& name,
                                       std::unique_ptr<base::Value> value);
 
   // Creates dictionary value for the pref described by |pref_name|.
   // If |controlling_pref| is not empty, it describes the pref that manages
   // |pref| via policy or extension.
-  virtual base::Value* CreateValueForPref(
+  virtual std::unique_ptr<base::Value> CreateValueForPref(
       const std::string& pref_name,
       const std::string& controlling_pref_name);
 
   typedef std::multimap<std::string, std::string> PreferenceCallbackMap;
   PreferenceCallbackMap pref_callback_map_;
 
  private:
   // Type of preference value received from the page. This doesn't map 1:1 to
   // Value::Type, since a TYPE_STRING can require custom processing.
   enum PrefType {
@@ skipping 79 matching lines @@
   typedef std::map<std::string, base::Callback<bool(const base::Value*)> >
       PrefChangeFilterMap;
   PrefChangeFilterMap pref_change_filters_;
 
   DISALLOW_COPY_AND_ASSIGN(CoreOptionsHandler);
 };
 
 }  // namespace options
 
 #endif  // CHROME_BROWSER_UI_WEBUI_OPTIONS_CORE_OPTIONS_HANDLER_H_