Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 281293002: Cast: Remove SenderRtcpEventSubscriber from cast library. (Closed)

Created:
6 years, 7 months ago by imcheng
Modified:
6 years, 7 months ago
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Cast: Remove SenderRtcpEventSubscriber from cast library. It is not used anymore after sender RTCP logs were removed in r270182. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270755

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -286 lines) Patch
M media/cast/cast.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M media/cast/cast_testing.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D media/cast/rtcp/sender_rtcp_event_subscriber.h View 1 chunk +0 lines, -69 lines 0 comments Download
D media/cast/rtcp/sender_rtcp_event_subscriber.cc View 1 chunk +0 lines, -92 lines 0 comments Download
D media/cast/rtcp/sender_rtcp_event_subscriber_unittest.cc View 1 chunk +0 lines, -120 lines 0 comments Download
M media/cast/video_sender/video_sender.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/cast/video_sender/video_sender.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
imcheng
6 years, 7 months ago (2014-05-14 20:56:35 UTC) #1
hubbe
lgtm
6 years, 7 months ago (2014-05-14 21:00:54 UTC) #2
imcheng
The CQ bit was checked by imcheng@chromium.org
6 years, 7 months ago (2014-05-14 21:05:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/imcheng@chromium.org/281293002/1
6 years, 7 months ago (2014-05-14 21:06:50 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-15 01:35:18 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-15 01:37:26 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/builds/16660)
6 years, 7 months ago (2014-05-15 01:37:26 UTC) #7
imcheng
The CQ bit was checked by imcheng@chromium.org
6 years, 7 months ago (2014-05-15 02:19:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/imcheng@chromium.org/281293002/1
6 years, 7 months ago (2014-05-15 02:20:55 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-15 03:03:47 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-15 03:07:21 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/builds/152161)
6 years, 7 months ago (2014-05-15 03:07:22 UTC) #12
Alpha Left Google
The CQ bit was checked by hclam@chromium.org
6 years, 7 months ago (2014-05-15 18:16:25 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/imcheng@chromium.org/281293002/1
6 years, 7 months ago (2014-05-15 18:17:16 UTC) #14
commit-bot: I haz the power
6 years, 7 months ago (2014-05-15 18:51:07 UTC) #15
Message was sent while issue was closed.
Change committed as 270755

Powered by Google App Engine
This is Rietveld 408576698