Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: components/prefs/pref_service.cc

Issue 2812863002: Pref service: Add a ScopedDictionaryPrefUpdate to track value changes. (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/prefs/pref_service.h ('k') | components/prefs/writeable_pref_store.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/prefs/pref_service.h" 5 #include "components/prefs/pref_service.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 474 matching lines...) Expand 10 before | Expand all | Expand 10 after
485 GetWriteFlags(pref)); 485 GetWriteFlags(pref));
486 } 486 }
487 return value; 487 return value;
488 } 488 }
489 489
490 void PrefService::ReportUserPrefChanged(const std::string& key) { 490 void PrefService::ReportUserPrefChanged(const std::string& key) {
491 DCHECK(CalledOnValidThread()); 491 DCHECK(CalledOnValidThread());
492 user_pref_store_->ReportValueChanged(key, GetWriteFlags(FindPreference(key))); 492 user_pref_store_->ReportValueChanged(key, GetWriteFlags(FindPreference(key)));
493 } 493 }
494 494
495 void PrefService::ReportUserPrefChanged(
496 const std::string& key,
497 std::set<std::vector<std::string>> path_components) {
498 DCHECK(CalledOnValidThread());
499 user_pref_store_->ReportSubValuesChanged(key, std::move(path_components),
500 GetWriteFlags(FindPreference(key)));
501 }
502
495 void PrefService::SetUserPrefValue(const std::string& path, 503 void PrefService::SetUserPrefValue(const std::string& path,
496 std::unique_ptr<base::Value> new_value) { 504 std::unique_ptr<base::Value> new_value) {
497 DCHECK(CalledOnValidThread()); 505 DCHECK(CalledOnValidThread());
498 506
499 const Preference* pref = FindPreference(path); 507 const Preference* pref = FindPreference(path);
500 if (!pref) { 508 if (!pref) {
501 NOTREACHED() << "Trying to write an unregistered pref: " << path; 509 NOTREACHED() << "Trying to write an unregistered pref: " << path;
502 return; 510 return;
503 } 511 }
504 if (pref->GetType() != new_value->GetType()) { 512 if (pref->GetType() != new_value->GetType()) {
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
615 DCHECK(found_value->IsType(default_type)); 623 DCHECK(found_value->IsType(default_type));
616 return found_value; 624 return found_value;
617 } else { 625 } else {
618 // Every registered preference has at least a default value. 626 // Every registered preference has at least a default value.
619 NOTREACHED() << "no valid value found for registered pref " << path; 627 NOTREACHED() << "no valid value found for registered pref " << path;
620 } 628 }
621 } 629 }
622 630
623 return NULL; 631 return NULL;
624 } 632 }
OLDNEW
« no previous file with comments | « components/prefs/pref_service.h ('k') | components/prefs/writeable_pref_store.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698