Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 281283002: ozone: evdev: Fix cursorless constructor (Closed)

Created:
6 years, 7 months ago by spang
Modified:
6 years, 7 months ago
Reviewers:
dnicoara, sadrul
CC:
chromium-reviews, rjkroege, kalyank, tdresser+watch_chromium.org, ozone-reviews_chromium.org
Visibility:
Public.

Description

ozone: evdev: Fix cursorless constructor EventFactoryEvdev does nothing without a DeviceManger. Remove the constructor that doesn't have one and make test/egltest explicitly pass NULL for cursor delegate. TBR=dnicoara BUG=none TEST=content_shell --ozone-platform=test NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270812

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -13 lines) Patch
M ui/events/ozone/evdev/event_factory_evdev.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/ozone/evdev/event_factory_evdev.cc View 1 1 chunk +0 lines, -10 lines 2 comments Download
M ui/ozone/platform/egltest/ozone_platform_egltest.cc View 3 chunks +6 lines, -1 line 0 comments Download
M ui/ozone/platform/test/ozone_platform_test.cc View 3 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
spang
6 years, 7 months ago (2014-05-15 19:35:11 UTC) #1
spang
The CQ bit was checked by spang@chromium.org
6 years, 7 months ago (2014-05-15 20:26:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/281283002/40001
6 years, 7 months ago (2014-05-15 20:26:50 UTC) #3
spang
The CQ bit was unchecked by spang@chromium.org
6 years, 7 months ago (2014-05-15 20:30:24 UTC) #4
spang
The CQ bit was checked by spang@chromium.org
6 years, 7 months ago (2014-05-15 20:30:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/281283002/40001
6 years, 7 months ago (2014-05-15 20:30:57 UTC) #6
dnicoara
lgtm https://codereview.chromium.org/281283002/diff/40001/ui/events/ozone/evdev/event_factory_evdev.cc File ui/events/ozone/evdev/event_factory_evdev.cc (right): https://codereview.chromium.org/281283002/diff/40001/ui/events/ozone/evdev/event_factory_evdev.cc#newcode223 ui/events/ozone/evdev/event_factory_evdev.cc:223: if (device_manager_ && !has_started_processing_events_) { nit: I suppose ...
6 years, 7 months ago (2014-05-15 20:31:34 UTC) #7
commit-bot: I haz the power
Change committed as 270812
6 years, 7 months ago (2014-05-15 20:55:38 UTC) #8
sadrul
6 years, 7 months ago (2014-05-16 03:11:51 UTC) #9
Message was sent while issue was closed. 
https://codereview.chromium.org/281283002/diff/40001/ui/events/ozone/evdev/ev...
File ui/events/ozone/evdev/event_factory_evdev.cc (right):

https://codereview.chromium.org/281283002/diff/40001/ui/events/ozone/evdev/ev...
ui/events/ozone/evdev/event_factory_evdev.cc:223: if (device_manager_ &&
!has_started_processing_events_) {
On 2014/05/15 20:31:35, dnicoara wrote:
> nit: I suppose device_manager_ should be removed from this if statement then.

I am including this in https://codereview.chromium.org/285303004/

Powered by Google App Engine
This is Rietveld 408576698