Issue 28128: Fix all places where we used the GetWinVersion function...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 28128: Fix all places where we used the GetWinVersion function... (Closed)

Created:
11 years, 9 months ago by Nicolas Sylvain

Modified:
9 years, 7 months ago

Reviewers:
rahulk, kuchhal, rvargas (doing something else), M-A Ruel

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Fix all places where we used the GetWinVersion function incorrectly. bug:7802 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10366

Total comments: 1

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -18 lines)			Patch
M	base/win_util.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	base/win_util_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/app/chrome_exe_main.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/browser_main_win.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/google_update.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/importer/ie_importer.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sandbox_policy.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/shell_integration.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/views/about_chrome_view.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/installer/setup/main.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/installer/util/shell_util.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/test/mini_installer_test/test.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

kuchhal

lgtm. the changes look ok but i think we would have to do some extensive ...

11 years, 9 months ago (2009-02-25 19:52:13 UTC) #2

Nicolas Sylvain

Oops, I had a typo in rick's name. uploaded new version. Nicolas

11 years, 9 months ago (2009-02-25 20:08:06 UTC) #3

Thanks, LGTM.