Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Unified Diff: components/open_from_clipboard/clipboard_recent_content_generic_unittest.cc

Issue 2812773002: Refactor Clipboard Last Modified Time Storage (Closed)
Patch Set: itri-state enum Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/open_from_clipboard/clipboard_recent_content_generic_unittest.cc
diff --git a/components/open_from_clipboard/clipboard_recent_content_generic_unittest.cc b/components/open_from_clipboard/clipboard_recent_content_generic_unittest.cc
index 1101c5e92e888b71677bb1db27dda44e13afd278..83b9ac943cfe9981d5d5797d7a36055c8693fe5a 100644
--- a/components/open_from_clipboard/clipboard_recent_content_generic_unittest.cc
+++ b/components/open_from_clipboard/clipboard_recent_content_generic_unittest.cc
@@ -65,8 +65,8 @@ TEST_F(ClipboardRecentContentGenericTest, RecognizesURLs) {
for (size_t i = 0; i < arraysize(test_data); ++i) {
test_clipboard_->WriteText(test_data[i].clipboard.data(),
test_data[i].clipboard.length());
- test_clipboard_->SetClipboardLastModifiedTime(
- now - base::TimeDelta::FromSeconds(10));
+ test_clipboard_->SetLastModifiedTime(now -
+ base::TimeDelta::FromSeconds(10));
GURL url;
EXPECT_EQ(test_data[i].expected_get_recent_url_value,
recent_content.GetRecentURLFromClipboard(&url))
@@ -79,13 +79,11 @@ TEST_F(ClipboardRecentContentGenericTest, OlderURLsNotSuggested) {
base::Time now = base::Time::Now();
std::string text = "http://example.com/";
test_clipboard_->WriteText(text.data(), text.length());
- test_clipboard_->SetClipboardLastModifiedTime(
- now - base::TimeDelta::FromSeconds(10));
+ test_clipboard_->SetLastModifiedTime(now - base::TimeDelta::FromSeconds(10));
GURL url;
EXPECT_TRUE(recent_content.GetRecentURLFromClipboard(&url));
// If the last modified time is days ago, the URL shouldn't be suggested.
- test_clipboard_->SetClipboardLastModifiedTime(now -
- base::TimeDelta::FromDays(2));
+ test_clipboard_->SetLastModifiedTime(now - base::TimeDelta::FromDays(2));
EXPECT_FALSE(recent_content.GetRecentURLFromClipboard(&url));
}
@@ -94,8 +92,7 @@ TEST_F(ClipboardRecentContentGenericTest, GetClipboardContentAge) {
base::Time now = base::Time::Now();
std::string text = " whether URL or not should not matter here.";
test_clipboard_->WriteText(text.data(), text.length());
- test_clipboard_->SetClipboardLastModifiedTime(
- now - base::TimeDelta::FromSeconds(32));
+ test_clipboard_->SetLastModifiedTime(now - base::TimeDelta::FromSeconds(32));
base::TimeDelta age = recent_content.GetClipboardContentAge();
// It's possible the GetClipboardContentAge() took some time, so allow a
// little slop (5 seconds) in this comparison; don't check for equality.
@@ -109,8 +106,7 @@ TEST_F(ClipboardRecentContentGenericTest, SuppressClipboardContent) {
base::Time now = base::Time::Now();
std::string text = "http://example.com/";
test_clipboard_->WriteText(text.data(), text.length());
- test_clipboard_->SetClipboardLastModifiedTime(
- now - base::TimeDelta::FromSeconds(10));
+ test_clipboard_->SetLastModifiedTime(now - base::TimeDelta::FromSeconds(10));
GURL url;
EXPECT_TRUE(recent_content.GetRecentURLFromClipboard(&url));
@@ -121,6 +117,6 @@ TEST_F(ClipboardRecentContentGenericTest, SuppressClipboardContent) {
// If the clipboard changes, even if to the same thing again, the content
// should be suggested again.
test_clipboard_->WriteText(text.data(), text.length());
- test_clipboard_->SetClipboardLastModifiedTime(now);
+ test_clipboard_->SetLastModifiedTime(now);
EXPECT_TRUE(recent_content.GetRecentURLFromClipboard(&url));
}
« no previous file with comments | « components/open_from_clipboard/clipboard_recent_content_generic.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698