🏠 Reader Mode info bar implementation

chrome/android/java/src/org/chromium/chrome/browser/infobar/ReaderModeInfoBar.java

Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/ReaderModeInfoBar.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/ReaderModeInfoBar.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/ReaderModeInfoBar.java
new file mode 100644
index 0000000000000000000000000000000000000000..e509e50471302fc8f1b6a2aef5dc275dd6252c35
--- /dev/null
+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/ReaderModeInfoBar.java
@@ -0,0 +1,87 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.chrome.browser.infobar;
+
+import android.graphics.Color;
+import android.util.TypedValue;
+import android.view.Gravity;
+import android.view.View;
+import android.view.ViewGroup.LayoutParams;
+import android.widget.TextView;
+
+import org.chromium.base.annotations.CalledByNative;
+import org.chromium.chrome.R;
+import org.chromium.chrome.browser.dom_distiller.ReaderModeManager;
+import org.chromium.chrome.browser.tab.Tab;
+
+/**
+ * This is the InfoBar implementation of the Reader Mode UI. This is used in place of the
+ * {@link OverlayPanel} implementation when Chrome Home is enabled.
+ */
+public class ReaderModeInfoBar extends InfoBar {
+    /** A handle to the {@link ReaderModeManager} to trigger page navigations. */
+    private static ReaderModeManager sManager;
+
+    /**
+     * Default constructor.
+     */
+    private ReaderModeInfoBar() {
+        super(R.drawable.infobar_mobile_friendly, null, null);
+    }
+
+    @Override
+    protected boolean usesCompactLayout() {
+        return true;
+    }
+
+    @Override
+    protected void createCompactLayoutContent(InfoBarCompactLayout layout) {
+        TextView prompt = new TextView(getContext());
+        prompt.setText(R.string.reader_view_text);
+        prompt.setSingleLine();
+        prompt.setTextSize(TypedValue.COMPLEX_UNIT_PX,
+                getContext().getResources().getDimension(R.dimen.overlay_panel_text_size));

[gone, 2017/04/11 17:51:43]

This is neither 14sp or 16sp.

go/clankstyles

[mdjones, 2017/04/11 20:38:57]

Changed to infobar_text_size.

+        prompt.setTextColor(Color.BLACK);

[gone, 2017/04/11 17:51:43]

Don't use black.  Same link as above.

[mdjones, 2017/04/11 20:38:57]

Done.

+        prompt.setGravity(Gravity.CENTER_VERTICAL);
+
+        prompt.setOnClickListener(new View.OnClickListener() {
+            @Override
+            public void onClick(View v) {
+                // TODO(mdjones): Trigger navigation from manager.
+            }
+        });
+
+        layout.addContent(prompt, 1f);
+
+        prompt.getLayoutParams().width = LayoutParams.MATCH_PARENT;
+        prompt.getLayoutParams().height = LayoutParams.MATCH_PARENT;

[gone, 2017/04/11 17:51:44]

You shouldn't be mucking about with the layout params, especially because you're
messing with linear layout parameters that mess with your 1.0f weight.  Why do
you think you need to do this?

[mdjones, 2017/04/11 20:38:57]

Didn't realize it automatically filled the parent. Removed.

+    }
+
+    public void onCloseButtonClicked() {
+        super.onCloseButtonClicked();
+
+        // TODO(mdjones): Notifiy the manager that the infobar was closed.
+    }
+
+    /**
+     * Create and show the Reader Mode {@link InfoBar}.
+     * @param tab The tab that the {@link InfoBar} should be shown in.
+     * @param manager The {@link ReaderModeManager} for this instance of Chrome.
+     */
+    public static void showReaderModeInfoBar(Tab tab, ReaderModeManager manager) {
+        sManager = manager;
+        nativeCreate(tab);
+    }
+
+    /**
+     * @return An instance of the {@link ReaderModeInfoBar}.
+     */
+    @CalledByNative
+    private static ReaderModeInfoBar create() {
+        return new ReaderModeInfoBar();
+    }
+
+    private static native void nativeCreate(Tab tab);
+}