Issue 2812733002: Fix renaming that got dropped

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2812733002: Fix renaming that got dropped (Closed)

Created:
3 years, 8 months ago by messick

Modified:
3 years, 8 months ago

Reviewers:
scheglov, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -9 lines)			Patch
	M	pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart	View		4 chunks	+6 lines, -5 lines	0 comments	Download
	M	pkg/analysis_server/lib/src/services/correction/assist.dart	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Total messages: 6 (2 generated)

messick

I thought I'd renamed PLAIN_OLE... to SIMPLE... but that change got lost. Also, it seems ...

3 years, 8 months ago (2017-04-10 22:07:31 UTC) #2

messick

3 years, 8 months ago (2017-04-11 16:53:03 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3406c4c1be028d780478b3ac752b9e083c13f0c7 (presubmit successful).