Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2812673002: Add missing checks for null imported/exportedLibraries. (Closed)

Created:
3 years, 8 months ago by scheglov
Modified:
3 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add missing checks for null imported/exportedLibraries. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/3e9d35813107a9a857b8d526f1364e33303fc08c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -23 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart/library_member_contributor.dart View 1 chunk +20 lines, -19 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element_resolver.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 8 months ago (2017-04-10 18:22:39 UTC) #1
Brian Wilkerson
lgtm
3 years, 8 months ago (2017-04-10 18:27:40 UTC) #2
scheglov
3 years, 8 months ago (2017-04-10 18:29:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3e9d35813107a9a857b8d526f1364e33303fc08c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698