Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2812623005: [dart:io] Fix crash in fetching the error message from BoringSSL (Closed)

Created:
3 years, 8 months ago by zra
Modified:
3 years, 8 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org, aarongreen_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[dart:io] Fix crash in fetching the error message from BoringSSL fixes #29307 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/d52a6a39d54fd2116aea7f2980500f92e4677e10

Patch Set 1 #

Patch Set 2 : Formatting #

Patch Set 3 : Formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -13 lines) Patch
M runtime/bin/secure_socket_boringssl.cc View 1 2 1 chunk +15 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
This is a patch from aarongreen@ to fix a crash in code that assembles BoringSSL ...
3 years, 8 months ago (2017-04-11 17:56:22 UTC) #2
rmacnak
lgtm
3 years, 8 months ago (2017-04-11 18:01:55 UTC) #3
zra
3 years, 8 months ago (2017-04-11 18:04:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
d52a6a39d54fd2116aea7f2980500f92e4677e10 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698