Fire a click event even when a clicked text node is removed in mouseup

third_party/WebKit/Source/core/input/EventHandler.cpp

Index: third_party/WebKit/Source/core/input/EventHandler.cpp
diff --git a/third_party/WebKit/Source/core/input/EventHandler.cpp b/third_party/WebKit/Source/core/input/EventHandler.cpp
index 4f8163d9dd5ffca42e4a9213fea3be8962e893ca..2ef84cb309cc03a7c26080a7b971a37d66624772 100644
--- a/third_party/WebKit/Source/core/input/EventHandler.cpp
+++ b/third_party/WebKit/Source/core/input/EventHandler.cpp
@@ -960,6 +960,9 @@ WebInputEventResult EventHandler::HandleMouseReleaseEvent(
   HitTestRequest request(hit_type);
   MouseEventWithHitTestResults mev =
       EventHandlingUtil::PerformMouseEventHitTest(frame_, request, mouse_event);
+  Node* release_node = (mev.InnerNode() && mev.InnerNode()->IsTextNode())

[kochi, 2017/04/12 06:44:39]

How about adding a TODO comment on this?

[hayato, 2017/04/12 06:52:22]

What kind of TODO comment?

[kochi, 2017/04/12 07:03:19]

If this is a tentative solution to the problem, have a pointer
to crbug and why. Probably this will be overridden by the
original CL https://codereview.chromium.org/2807123002/ soon,
so I do not bother you for adding comment here much.

[hayato, 2017/04/12 07:12:07]

That kind of TODO comment should be a file level TODO comment. That should not
be added on this particular line. That is rather confusing, I think.

+                           ? FlatTreeTraversal::Parent(*mev.InnerNode())

[yosin_UTC9, 2017/04/12 06:10:44]

Do we need to use flat tree parent?
Can we distribute Text node directly into shadow tree?

[hayato, 2017/04/12 06:16:06]

Yes. Text node can be distributed.

+                           : mev.InnerNode();
   LocalFrame* subframe =
       capturing_mouse_events_node_.Get()
           ? SubframeForTargetNode(capturing_mouse_events_node_.Get())
@@ -992,7 +995,7 @@ WebInputEventResult EventHandler::HandleMouseReleaseEvent(
       mev.Event(), Vector<WebMouseEvent>());
 
   WebInputEventResult click_event_result =
-      mouse_event_manager_->DispatchMouseClickIfNeeded(mev);
+      mouse_event_manager_->DispatchMouseClickIfNeeded(mev, release_node);
 
   scroll_manager_->ClearResizeScrollableArea(false);