Issue 28126: Hide the autocomplete popup when the browser window is moved

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 28126: Hide the autocomplete popup when the browser window is moved (Closed)

Created:
11 years, 10 months ago by jcampan

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

This CL causes the autofill popup to hide when the browser window is moved or resized. TEST=Bring up an autofill popup in a form, move the browser. The autofill popup should be closed. BUG=7401 R=ben Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10384

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -2 lines)			Patch
M	chrome/browser/renderer_host/render_view_host.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/web_contents.h	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/views/frame/aero_glass_frame.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/views/frame/aero_glass_frame.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/views/frame/browser_view.h	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/views/frame/browser_view.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/views/frame/opaque_frame.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/views/frame/opaque_frame.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/common/render_messages_internal.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/renderer/render_view.h	View	1 2	2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/renderer/render_view.cc	View		3 chunks	+13 lines, -0 lines	0 comments	Download
M	chrome/renderer/render_widget.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/views/widget_win.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	webkit/glue/webview.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	webkit/glue/webview_impl.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/glue/webview_impl.cc	View	1 2 3	2 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

11 years, 10 months ago (2009-02-25 20:30:24 UTC) #2

OK

http://codereview.chromium.org/28126/diff/1/13
File chrome/browser/renderer_host/render_view_host.h (right):

http://codereview.chromium.org/28126/diff/1/13#newcode409
Line 409: void MoveOrResizeStarted();
You might name this method to indicate that it's the frame that moved.

WindowMoveOrResizeStarted() or something.

You might also give your autofill popup thing as an example of why the
RenderViewHost cares about this notification.

Expand Messages | Collapse Messages