Add integration tests for edit.getAssists and edit.getFixes.

pkg/analysis_server/test/integration/integration_tests.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.integration.analysis;
 
 import 'dart:async';
 import 'dart:collection';
 import 'dart:convert';
 import 'dart:io';
@@ skipping 441 matching lines @@
 }
 
 /**
  * Instances of the class [Server] manage a connection to a server process, and
  * facilitate communication to and from the server.
  */
 class Server {
   /**
    * Server process object, or null if server hasn't been started yet.
    */
-  Process _process = null;
+  Process _process;
 
   /**
    * Commands that have been sent to the server but not yet acknowledged, and
    * the [Completer] objects which should be completed when acknowledgement is
    * received.
    */
   final Map<String, Completer> _pendingCommands = <String, Completer>{};
 
   /**
    * Number which should be used to compute the 'id' to send in the next command
@@ skipping 174 matching lines @@
     _recordStdio('SEND: $line');
     _process.stdin.add(UTF8.encoder.convert("$line\n"));
     return completer.future;
   }
 
   /**
    * Start the server. If [profileServer] is `true`, the server will be started
    * with "--observe" and "--pause-isolates-on-exit", allowing the observatory
    * to be used.
    */
-  Future start(
-      {bool checked: true,
-      int diagnosticPort,
-      bool enableNewAnalysisDriver: false,
-      bool profileServer: false,
-      String sdkPath,
-      int servicesPort,
-      bool useAnalysisHighlight2: false}) {
+  Future start({
+    bool checked: true,
+    int diagnosticPort,
+    bool enableNewAnalysisDriver: false,
+    bool profileServer: false,
+    String sdkPath,
+    int servicesPort,
+    bool useAnalysisHighlight2: false,
+  }) async {
     if (_process != null) {
       throw new Exception('Process already started');
     }
     _time.start();
     String dartBinary = Platform.executable;
     String rootDir =
         findRoot(Platform.script.toFilePath(windows: Platform.isWindows));
     String serverPath = normalize(join(rootDir, 'bin', 'server.dart'));
     List<String> arguments = [];
     //
@@ skipping 35 matching lines @@
     if (useAnalysisHighlight2) {
       arguments.add('--useAnalysisHighlight2');
     }
     if (!enableNewAnalysisDriver) {
       arguments.add('--disable-new-analysis-driver');
     }
 //    print('Launching $serverPath');
 //    print('$dartBinary ${arguments.join(' ')}');
     // TODO(devoncarew): We could experiment with instead launching the analysis
     // server in a separate isolate. This would make it easier to debug the
-    // integration tests, and would like speed the tests up as well.
-    return Process.start(dartBinary, arguments).then((Process process) {
-      _process = process;
-      process.exitCode.then((int code) {
-        if (code != 0) {
-          _badDataFromServer('server terminated with exit code $code');
-        }
-      });
+    // integration tests, and would likely speed the tests up as well.
+    _process = await Process.start(dartBinary, arguments);
+    _process.exitCode.then((int code) {
+      if (code != 0) {
+        _badDataFromServer('server terminated with exit code $code');
+      }
     });
   }
 
   /**
    * Deal with bad data received from the server.
    */
   void _badDataFromServer(String details, {bool silent: false}) {
     if (!silent) {
       _recordStdio('BAD DATA FROM SERVER: $details');
     }
@@ skipping 252 matching lines @@
   void populateMismatches(item, List<MismatchDescriber> mismatches);
 
   /**
    * Create a [MismatchDescriber] describing a mismatch with a simple string.
    */
   MismatchDescriber simpleDescription(String description) =>
       (Description mismatchDescription) {
         mismatchDescription.add(description);
       };
 }