[DMC #1] Refactor DocumentMarkerController on top of new DocumentMarkerListEditor class

third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h

Index: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h
diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h
index 67ea88da93bdc582fe9c7d140e271cca5d7e0510..3f43df34c72d92e36f822f7c134ec1ea66a95af5 100644
--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h
+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h
@@ -53,6 +53,22 @@ class MarkerRemoverPredicate final {
   Vector<String> words_;
 };
 
+class DocumentMarkerListEditor {
+ public:
+  using MarkerList = HeapVector<Member<RenderedDocumentMarker>>;
+
+  static void AddMarker(MarkerList*, const DocumentMarker*);
+
+  static bool RemoveMarkers(MarkerList*, unsigned start_offset, int length);
+  static bool ShiftMarkers(MarkerList*,

[yosin_UTC9, 2017/04/17 06:59:01]

nit: Please add a comment for |bool| return value.

+                           unsigned offset,
+                           unsigned old_length,
+                           unsigned new_length);
+
+ private:
+  static void MergeOverlapping(MarkerList*, RenderedDocumentMarker* to_insert);
+};
+
 class CORE_EXPORT DocumentMarkerController final
     : public GarbageCollected<DocumentMarkerController>,
       public SynchronousMutationObserver {
@@ -133,7 +149,6 @@ class CORE_EXPORT DocumentMarkerController final
   using MarkerLists =
       HeapVector<Member<MarkerList>, DocumentMarker::kMarkerTypeIndexesCount>;
   using MarkerMap = HeapHashMap<WeakMember<const Node>, Member<MarkerLists>>;
-  void MergeOverlapping(MarkerList*, RenderedDocumentMarker*);
   bool PossiblyHasMarkers(DocumentMarker::MarkerTypes);
   void RemoveMarkersFromList(MarkerMap::iterator, DocumentMarker::MarkerTypes);
   void RemoveMarkers(TextIterator&, DocumentMarker::MarkerTypes);