[DMC #1] Refactor DocumentMarkerController on top of new DocumentMarkerListEditor class

third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
  * reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
  * (http://www.torchmobile.com/)
  * Copyright (C) Research In Motion Limited 2010. All rights reserved.
@@ skipping 59 matching lines @@
     case DocumentMarker::kComposition:
       return DocumentMarker::kCompositionMarkerIndex;
   }
 
   NOTREACHED();
   return DocumentMarker::kSpellingMarkerIndex;
 }
 
 }  // namespace
 
+static bool StartsFurther(const Member<DocumentMarker>& lhv,
+                          const DocumentMarker* rhv) {
+  return lhv->StartOffset() < rhv->StartOffset();
+}
+
+static bool EndsBefore(size_t start_offset, const Member<DocumentMarker>& rhv) {
+  return start_offset < rhv->EndOffset();
+}
+
+static bool CompareByStart(const Member<DocumentMarker>& lhv,
+                           const Member<DocumentMarker>& rhv) {
+  return lhv->StartOffset() < rhv->StartOffset();
+}
+
+static bool DoesNotOverlap(const Member<DocumentMarker>& lhv,
+                           const DocumentMarker* rhv) {
+  return lhv->EndOffset() < rhv->StartOffset();
+}
+
+bool DocumentMarkerList::IsEmpty() const {
+  return markers_.IsEmpty();
+}
+
+void DocumentMarkerList::Add(DocumentMarker* marker) {
+  if (markers_.IsEmpty() ||
+      markers_.back()->EndOffset() < marker->StartOffset()) {
+    markers_.push_back(marker);
+  } else {
+    if (marker->GetType() != DocumentMarker::kTextMatch &&
+        marker->GetType() != DocumentMarker::kComposition) {
+      MergeOverlapping(marker);
+    } else {
+      const auto pos = std::lower_bound(markers_.begin(), markers_.end(),
+                                        marker, StartsFurther);
+      markers_.insert(pos - markers_.begin(), marker);
+    }
+  }
+}
+
+void DocumentMarkerList::Clear() {
+  markers_.Clear();
+}
+
+void DocumentMarkerList::AppendMarkersToInputList(
+    DocumentMarkerVector* input_list) const {
+  input_list->AppendVector(markers_);
+}
+
+bool DocumentMarkerList::MoveMarkers(int length, DocumentMarkerList* dst_list) {
+  DCHECK_GT(length, 0);
+  bool didMoveMarker = false;
+  unsigned end_offset = length - 1;
+
+  DocumentMarkerVector::iterator it;
+  for (it = markers_.begin(); it != markers_.end(); ++it) {
+    DocumentMarker& marker = **it;
+    if (marker.StartOffset() > end_offset)
+      break;
+
+    // pin the marker to the specified range and apply the shift delta
+    if (marker.EndOffset() > end_offset)
+      marker.SetEndOffset(end_offset);
+
+    dst_list->Add(&marker);
+    didMoveMarker = true;
+  }
+
+  // Remove the range of markers that were moved to dstNode
+  markers_.erase(0, it - markers_.begin());
+
+  return didMoveMarker;
+}
+
+bool DocumentMarkerList::RemoveMarkers(unsigned start_offset, int length) {
+  unsigned end_offset = start_offset + length;
+
+  const auto startPos = std::upper_bound(markers_.begin(), markers_.end(),
+                                         start_offset, EndsBefore);
+  auto it = startPos;
+  for (; it != markers_.end(); ++it) {
+    if ((*it)->StartOffset() >= end_offset)
+      break;
+  }
+
+  // it should now point at the first marker *not* to be removed (or at
+  // markers_->end())
+  markers_.erase(startPos - markers_.begin(), it - startPos);
+
+  if (it == startPos)
+    return false;
+
+  return true;
+}
+
+bool DocumentMarkerList::ShiftMarkers(unsigned offset,
+                                      unsigned old_length,
+                                      unsigned new_length) {
+  DocumentMarkerVector newMarkerList;
+  bool didShiftMarker = false;
+  for (Member<DocumentMarker> marker : markers_) {
+    Optional<DocumentMarker::MarkerOffsets> result =
+        marker->ComputeOffsetsAfterShift(offset, old_length, new_length);
+
+    if (result == WTF::kNullopt) {
+      didShiftMarker = true;
+      continue;
+    }
+
+    if (result.value().start_offset != marker->StartOffset() ||
+        result.value().end_offset != marker->EndOffset()) {
+      marker->SetStartOffset(result.value().start_offset);
+      marker->SetEndOffset(result.value().end_offset);
+
+      didShiftMarker = true;
+    }
+
+    newMarkerList.push_back(marker);
+  }
+
+  swap(markers_, newMarkerList);
+  return didShiftMarker;
+}
+
+void DocumentMarkerList::MergeOverlapping(DocumentMarker* marker) {
+  auto first_overlapping = std::lower_bound(markers_.begin(), markers_.end(),
+                                            marker, DoesNotOverlap);
+  size_t index = first_overlapping - markers_.begin();
+  markers_.insert(index, marker);
+  const auto inserted = markers_.begin() + index;
+  first_overlapping = inserted + 1;
+  for (auto i = first_overlapping;
+       i != markers_.end() &&
+       (*i)->StartOffset() <= (*inserted)->EndOffset();) {
+    (*inserted)->SetStartOffset(
+        std::min((*inserted)->StartOffset(), (*i)->StartOffset()));
+    (*inserted)->SetEndOffset(
+        std::max((*inserted)->EndOffset(), (*i)->EndOffset()));
+    markers_.erase(i - markers_.begin());
+  }
+}
+
+DEFINE_TRACE(DocumentMarkerList) {
+  visitor->Trace(markers_);
+}
+
 inline bool DocumentMarkerController::PossiblyHasMarkers(
     DocumentMarker::MarkerTypes types) {
   return possibly_existing_marker_types_.Intersects(types);
 }
 
 DocumentMarkerController::DocumentMarkerController(Document& document)
     : possibly_existing_marker_types_(0), document_(&document) {
   SetContext(&document);
 }
 
 void DocumentMarkerController::Clear() {
   markers_.Clear();
   possibly_existing_marker_types_ = 0;
 }
 
 void DocumentMarkerController::AddMarker(const Position& start,
                                          const Position& end,
                                          DocumentMarker::MarkerType type,
                                          const String& description) {
   // Use a TextIterator to visit the potentially multiple nodes the range
   // covers.
   for (TextIterator marked_text(start, end); !marked_text.AtEnd();
        marked_text.Advance()) {
-    AddMarker(
-        marked_text.CurrentContainer(),
-        DocumentMarker(type, marked_text.StartOffsetInCurrentContainer(),
-                       marked_text.EndOffsetInCurrentContainer(), description));
+    AddMarker(marked_text.CurrentContainer(),
+              new DocumentMarker(
+                  type, marked_text.StartOffsetInCurrentContainer(),
+                  marked_text.EndOffsetInCurrentContainer(), description));
   }
 }
 
 void DocumentMarkerController::AddTextMatchMarker(
     const EphemeralRange& range,
     DocumentMarker::MatchStatus match_status) {
   DCHECK(!document_->NeedsLayoutTreeUpdate());
 
   // Use a TextIterator to visit the potentially multiple nodes the range
   // covers.
   for (TextIterator marked_text(range.StartPosition(), range.EndPosition());
        !marked_text.AtEnd(); marked_text.Advance()) {
     AddMarker(marked_text.CurrentContainer(),
-              DocumentMarker(marked_text.StartOffsetInCurrentContainer(),
-                             marked_text.EndOffsetInCurrentContainer(),
-                             match_status));
+              new DocumentMarker(marked_text.StartOffsetInCurrentContainer(),
+                                 marked_text.EndOffsetInCurrentContainer(),
+                                 match_status));
   }
   // Don't invalidate tickmarks here. TextFinder invalidates tickmarks using a
   // throttling algorithm. crbug.com/6819.
 }
 
 void DocumentMarkerController::AddCompositionMarker(const Position& start,
                                                     const Position& end,
                                                     Color underline_color,
                                                     bool thick,
                                                     Color background_color) {
   DCHECK(!document_->NeedsLayoutTreeUpdate());
 
   for (TextIterator marked_text(start, end); !marked_text.AtEnd();
-       marked_text.Advance())
+       marked_text.Advance()) {
     AddMarker(marked_text.CurrentContainer(),
-              DocumentMarker(marked_text.StartOffsetInCurrentContainer(),
-                             marked_text.EndOffsetInCurrentContainer(),
-                             underline_color, thick, background_color));
+              new DocumentMarker(marked_text.StartOffsetInCurrentContainer(),
+                                 marked_text.EndOffsetInCurrentContainer(),
+                                 underline_color, thick, background_color));
+  }
 }
 
 void DocumentMarkerController::PrepareForDestruction() {
   Clear();
 }
 
 void DocumentMarkerController::RemoveMarkers(
     TextIterator& marked_text,
     DocumentMarker::MarkerTypes marker_types) {
   for (; !marked_text.AtEnd(); marked_text.Advance()) {
@@ skipping 10 matching lines @@
 
 void DocumentMarkerController::RemoveMarkers(
     const EphemeralRange& range,
     DocumentMarker::MarkerTypes marker_types) {
   DCHECK(!document_->NeedsLayoutTreeUpdate());
 
   TextIterator marked_text(range.StartPosition(), range.EndPosition());
   DocumentMarkerController::RemoveMarkers(marked_text, marker_types);
 }
 
-static bool StartsFurther(const Member<RenderedDocumentMarker>& lhv,

[Xiaocheng, 2017/04/13 02:39:51]

There's no need to touch these functions if we keep RenderedDocumentMarker in
this patch. That's going to make the patch smaller.

-                          const DocumentMarker* rhv) {
-  return lhv->StartOffset() < rhv->StartOffset();
-}
-
-static bool EndsBefore(size_t start_offset,
-                       const Member<RenderedDocumentMarker>& rhv) {
-  return start_offset < rhv->EndOffset();
-}
-
-static bool CompareByStart(const Member<DocumentMarker>& lhv,
-                           const Member<DocumentMarker>& rhv) {
-  return lhv->StartOffset() < rhv->StartOffset();
-}
-
-static bool DoesNotOverlap(const Member<RenderedDocumentMarker>& lhv,
-                           const DocumentMarker* rhv) {
-  return lhv->EndOffset() < rhv->StartOffset();
-}
-
 static void UpdateMarkerRenderedRect(const Node& node,
                                      RenderedDocumentMarker& marker) {
   Range* range = Range::Create(node.GetDocument());
   // The offsets of the marker may be out-dated, so check for exceptions.
   DummyExceptionStateForTesting exception_state;
   range->setStart(&const_cast<Node&>(node), marker.StartOffset(),
                   exception_state);
   if (!exception_state.HadException()) {
     range->setEnd(&const_cast<Node&>(node), marker.EndOffset(),
                   IGNORE_EXCEPTION_FOR_TESTING);
   }
   if (!exception_state.HadException()) {
     // TODO(yosin): Once we have a |EphemeralRange| version of |boundingBox()|,
     // we should use it instead of |Range| version.
     marker.SetRenderedRect(LayoutRect(range->BoundingBox()));
   } else {
     marker.NullifyRenderedRect();
   }
   range->Dispose();
 }
 
 // Markers are stored in order sorted by their start offset.
 // Markers of the same type do not overlap each other.
 
 void DocumentMarkerController::AddMarker(Node* node,
-                                         const DocumentMarker& new_marker) {
-  DCHECK_GE(new_marker.EndOffset(), new_marker.StartOffset());
-  if (new_marker.EndOffset() == new_marker.StartOffset())
+                                         const DocumentMarker* new_marker) {
+  DCHECK_GE(new_marker->EndOffset(), new_marker->StartOffset());
+  if (new_marker->EndOffset() == new_marker->StartOffset())
     return;
 
-  possibly_existing_marker_types_.Add(new_marker.GetType());
+  possibly_existing_marker_types_.Add(new_marker->GetType());
 
   Member<MarkerLists>& markers =
       markers_.insert(node, nullptr).stored_value->value;
   if (!markers) {
     markers = new MarkerLists;
     markers->Grow(DocumentMarker::kMarkerTypeIndexesCount);
   }
 
   DocumentMarker::MarkerTypeIndex marker_list_index =
-      MarkerTypeToMarkerIndex(new_marker.GetType());
+      MarkerTypeToMarkerIndex(new_marker->GetType());
   if (!markers->at(marker_list_index)) {
-    markers->at(marker_list_index) = new MarkerList;
+    markers->at(marker_list_index) = new DocumentMarkerList;
   }
 
-  Member<MarkerList>& list = markers->at(marker_list_index);
+  DocumentMarkerList* list = markers->at(marker_list_index);
   RenderedDocumentMarker* new_rendered_marker =
-      RenderedDocumentMarker::Create(new_marker);
-  if (list->IsEmpty() || list->back()->EndOffset() < new_marker.StartOffset()) {
-    list->push_back(new_rendered_marker);
-  } else {
-    if (new_marker.GetType() != DocumentMarker::kTextMatch &&
-        new_marker.GetType() != DocumentMarker::kComposition) {
-      MergeOverlapping(list.Get(), new_rendered_marker);
-    } else {
-      MarkerList::iterator pos = std::lower_bound(list->begin(), list->end(),
-                                                  &new_marker, StartsFurther);
-      list->insert(pos - list->begin(), new_rendered_marker);
-    }
-  }
+      RenderedDocumentMarker::Create(*new_marker);
+  list->Add(new_rendered_marker);
 
   // repaint the affected node
   if (node->GetLayoutObject()) {
     node->GetLayoutObject()->SetShouldDoFullPaintInvalidation(
         kPaintInvalidationDocumentMarkerChange);
   }
 }
 
-void DocumentMarkerController::MergeOverlapping(

[Xiaocheng, 2017/04/13 02:39:51]

DML::MergeOverlapping can be put here, so that it is clear that the old impl is
not thrown away.

-    MarkerList* list,
-    RenderedDocumentMarker* to_insert) {
-  MarkerList::iterator first_overlapping =
-      std::lower_bound(list->begin(), list->end(), to_insert, DoesNotOverlap);
-  size_t index = first_overlapping - list->begin();
-  list->insert(index, to_insert);
-  MarkerList::iterator inserted = list->begin() + index;
-  first_overlapping = inserted + 1;
-  for (MarkerList::iterator i = first_overlapping;
-       i != list->end() && (*i)->StartOffset() <= (*inserted)->EndOffset();) {
-    (*inserted)->SetStartOffset(
-        std::min((*inserted)->StartOffset(), (*i)->StartOffset()));
-    (*inserted)->SetEndOffset(
-        std::max((*inserted)->EndOffset(), (*i)->EndOffset()));
-    list->erase(i - list->begin());
-  }
-}
-
 // Moves markers from src_node to dst_node. Markers are moved if their start
 // offset is less than length. Markers that run past that point are truncated.
 void DocumentMarkerController::MoveMarkers(Node* src_node,
                                            int length,
                                            Node* dst_node) {
   if (length <= 0)
     return;
 
   if (!PossiblyHasMarkers(DocumentMarker::AllMarkers()))
     return;
   DCHECK(!markers_.IsEmpty());
 
-  MarkerLists* markers = markers_.at(src_node);
-  if (!markers)
+  MarkerLists* src_markers = markers_.at(src_node);
+  if (!src_markers)
     return;
 
+  Member<MarkerLists>& dst_markers =
+      markers_.insert(dst_node, nullptr).stored_value->value;
+  if (!dst_markers) {
+    dst_markers = new MarkerLists;
+    dst_markers->Grow(DocumentMarker::kMarkerTypeIndexesCount);
+  }
+
   bool doc_dirty = false;
-  for (Member<MarkerList> list : *markers) {
-    if (!list)
+  for (size_t marker_list_index = 0; marker_list_index < src_markers->size();
+       marker_list_index++) {
+    DocumentMarkerList* src_list = src_markers->at(marker_list_index);
+    if (!src_list)
       continue;
 
-    unsigned end_offset = length - 1;
-    MarkerList::iterator it;
-    for (it = list->begin(); it != list->end(); ++it) {
-      DocumentMarker* marker = it->Get();
-
-      // stop if we are now past the specified range
-      if (marker->StartOffset() > end_offset)
-        break;
-
-      // pin the marker to the specified range
-      doc_dirty = true;
-      if (marker->EndOffset() > end_offset)
-        marker->SetEndOffset(end_offset);
-
-      AddMarker(dst_node, *marker);
+    if (!dst_markers->at(marker_list_index)) {
+      dst_markers->at(marker_list_index) = new DocumentMarkerList;
     }
 
-    // Remove the range of markers that were moved to dstNode
-    list->erase(0, it - list->begin());
+    src_list->MoveMarkers(length, dst_markers->at(marker_list_index));
   }
 
   // repaint the affected node
   if (doc_dirty && dst_node->GetLayoutObject()) {
     dst_node->GetLayoutObject()->SetShouldDoFullPaintInvalidation(
         kPaintInvalidationDocumentMarkerChange);
   }
 }
 
 void DocumentMarkerController::RemoveMarkers(
     Node* node,
     unsigned start_offset,
     int length,
     DocumentMarker::MarkerTypes marker_types) {
   if (length <= 0)
     return;
 
   if (!PossiblyHasMarkers(marker_types))
     return;
   DCHECK(!(markers_.IsEmpty()));
 
   MarkerLists* markers = markers_.at(node);
   if (!markers)
     return;
 
   bool doc_dirty = false;
   size_t empty_lists_count = 0;
-  for (size_t marker_list_index = 0;
-       marker_list_index < DocumentMarker::kMarkerTypeIndexesCount;
-       ++marker_list_index) {
-    Member<MarkerList>& list = (*markers)[marker_list_index];
+  for (DocumentMarker::MarkerType type : DocumentMarker::AllMarkers()) {
+    size_t marker_list_index = MarkerTypeToMarkerIndex(type);
+
+    Member<DocumentMarkerList>& list = (*markers)[marker_list_index];
     if (!list || list->IsEmpty()) {
       if (list.Get() && list->IsEmpty())
         list.Clear();
       ++empty_lists_count;
       continue;
     }
-    if (!marker_types.Contains((*list->begin())->GetType()))
+    if (!marker_types.Contains(type))
       continue;
-    unsigned end_offset = start_offset + length;
-    MarkerList::iterator start_pos =
-        std::upper_bound(list->begin(), list->end(), start_offset, EndsBefore);
-    for (MarkerList::iterator i = start_pos; i != list->end();) {
-      DocumentMarker marker(*i->Get());
 
-      // markers are returned in order, so stop if we are now past the specified
-      // range
-      if (marker.StartOffset() >= end_offset)
-        break;
-
-      list->erase(i - list->begin());
-      doc_dirty = true;
-    }
+    doc_dirty = list->RemoveMarkers(start_offset, length) || doc_dirty;
 
     if (list->IsEmpty()) {
       list.Clear();
       ++empty_lists_count;
     }
   }
 
   if (empty_lists_count == DocumentMarker::kMarkerTypeIndexesCount) {
     markers_.erase(node);
     if (markers_.IsEmpty())
       possibly_existing_marker_types_ = 0;
   }
 
   // repaint the affected node
   if (doc_dirty && node->GetLayoutObject()) {
     node->GetLayoutObject()->SetShouldDoFullPaintInvalidation(
         kPaintInvalidationDocumentMarkerChange);
   }
 }
 
 DocumentMarkerVector DocumentMarkerController::MarkersFor(
     Node* node,
     DocumentMarker::MarkerTypes marker_types) {
   DocumentMarkerVector result;
 
   MarkerLists* markers = markers_.at(node);
   if (!markers)
     return result;
 
-  for (size_t marker_list_index = 0;
-       marker_list_index < DocumentMarker::kMarkerTypeIndexesCount;
-       ++marker_list_index) {
-    Member<MarkerList>& list = (*markers)[marker_list_index];
-    if (!list || list->IsEmpty() ||
-        !marker_types.Contains((*list->begin())->GetType()))
+  for (DocumentMarker::MarkerType type : DocumentMarker::AllMarkers()) {
+    size_t marker_list_index = MarkerTypeToMarkerIndex(type);
+
+    DocumentMarkerList* list = (*markers)[marker_list_index];
+    if (!list || list->IsEmpty() || !marker_types.Contains(type))
       continue;
 
-    for (size_t i = 0; i < list->size(); ++i)
-      result.push_back(list->at(i).Get());
+    list->AppendMarkersToInputList(&result);
   }
 
   std::sort(result.begin(), result.end(), CompareByStart);
   return result;
 }
 
 DocumentMarkerVector DocumentMarkerController::Markers() {
   DocumentMarkerVector result;
   for (MarkerMap::iterator i = markers_.begin(); i != markers_.end(); ++i) {
     MarkerLists* markers = i->value.Get();
     for (size_t marker_list_index = 0;
          marker_list_index < DocumentMarker::kMarkerTypeIndexesCount;
          ++marker_list_index) {
-      Member<MarkerList>& list = (*markers)[marker_list_index];
-      for (size_t j = 0; list.Get() && j < list->size(); ++j)
-        result.push_back(list->at(j).Get());
+      DocumentMarkerList* list = (*markers)[marker_list_index];
+      if (!list)
+        continue;
+
+      list->AppendMarkersToInputList(&result);
     }
   }
+
   std::sort(result.begin(), result.end(), CompareByStart);
   return result;
 }
 
 DocumentMarkerVector DocumentMarkerController::MarkersInRange(
     const EphemeralRange& range,
     DocumentMarker::MarkerTypes marker_types) {
   if (!PossiblyHasMarkers(marker_types))
     return DocumentMarkerVector();
 
@@ skipping 30 matching lines @@
     return result;
   DCHECK(!(markers_.IsEmpty()));
 
   // outer loop: process each node
   MarkerMap::iterator end = markers_.end();
   for (MarkerMap::iterator node_iterator = markers_.begin();
        node_iterator != end; ++node_iterator) {
     // inner loop; process each marker in this node
     const Node& node = *node_iterator->key;
     MarkerLists* markers = node_iterator->value.Get();
-    for (size_t marker_list_index = 0;
-         marker_list_index < DocumentMarker::kMarkerTypeIndexesCount;
-         ++marker_list_index) {
-      Member<MarkerList>& list = (*markers)[marker_list_index];
-      if (!list || list->IsEmpty() ||
-          (*list->begin())->GetType() != marker_type)
+    for (DocumentMarker::MarkerType type : DocumentMarker::AllMarkers()) {
+      size_t marker_list_index = MarkerTypeToMarkerIndex(type);
+      DocumentMarkerList* list = (*markers)[marker_list_index];
+      if (!list || list->IsEmpty() || type != marker_type)
         continue;
-      for (unsigned marker_index = 0; marker_index < list->size();
-           ++marker_index) {
-        RenderedDocumentMarker* marker = list->at(marker_index).Get();
-        UpdateMarkerRenderedRectIfNeeded(node, *marker);
-        if (!marker->IsRendered())
+      DocumentMarkerVector markers_in_list;
+      list->AppendMarkersToInputList(&markers_in_list);
+      for (DocumentMarker* marker : markers_in_list) {
+        RenderedDocumentMarker* rendered_marker =
+            ToRenderedDocumentMarker(marker);
+        UpdateMarkerRenderedRectIfNeeded(node, *rendered_marker);
+        if (!rendered_marker->IsRendered())
           continue;
-        result.push_back(marker->RenderedRect());
+        result.push_back(rendered_marker->RenderedRect());
       }
     }
   }
 
   return result;
 }
 
 static void InvalidatePaintForTickmarks(const Node& node) {
   if (FrameView* frame_view = node.GetDocument().View())
     frame_view->InvalidatePaintForTickmarks();
 }
 
 void DocumentMarkerController::UpdateMarkerRenderedRectIfNeeded(
     const Node& node,
     RenderedDocumentMarker& marker) {
   DCHECK(!document_->View() || !document_->View()->NeedsLayout());
   DCHECK(!document_->NeedsLayoutTreeUpdate());
   if (!marker.IsValid())
     UpdateMarkerRenderedRect(node, marker);
 }
 
 void DocumentMarkerController::InvalidateRectsForMarkersInNode(
     const Node& node) {
   MarkerLists* markers = markers_.at(&node);
 
-  for (auto& marker_list : *markers) {
+  for (DocumentMarkerList* marker_list : *markers) {
     if (!marker_list || marker_list->IsEmpty())
       continue;
 
-    for (auto& marker : *marker_list)
-      marker->Invalidate();
+    DocumentMarkerVector markers_in_list;
+    marker_list->AppendMarkersToInputList(&markers_in_list);
 
-    if (marker_list->front()->GetType() == DocumentMarker::kTextMatch)
+    for (DocumentMarker* marker : markers_in_list)
+      ToRenderedDocumentMarker(marker)->Invalidate();
+
+    if (markers_in_list.front()->GetType() == DocumentMarker::kTextMatch)
       InvalidatePaintForTickmarks(node);
   }
 }
 
 void DocumentMarkerController::InvalidateRectsForAllMarkers() {
   for (auto& node_markers : markers_) {
     const Node& node = *node_markers.key;
-    for (auto& marker_list : *node_markers.value) {
+    for (DocumentMarkerList* marker_list : *node_markers.value) {
       if (!marker_list || marker_list->IsEmpty())
         continue;
 
-      for (auto& marker : *marker_list)
-        marker->Invalidate();
+      DocumentMarkerVector markers_in_list;
+      marker_list->AppendMarkersToInputList(&markers_in_list);
+      for (DocumentMarker* marker : markers_in_list)
+        ToRenderedDocumentMarker(marker)->Invalidate();
 
-      if (marker_list->front()->GetType() == DocumentMarker::kTextMatch)
+      if (markers_in_list.front()->GetType() == DocumentMarker::kTextMatch)
         InvalidatePaintForTickmarks(node);
     }
   }
 }
 
 DEFINE_TRACE(DocumentMarkerController) {
   visitor->Trace(markers_);
   visitor->Trace(document_);
   SynchronousMutationObserver::Trace(visitor);
 }
@@ skipping 13 matching lines @@
 void DocumentMarkerController::RemoveMarkers(
     const MarkerRemoverPredicate& should_remove_marker) {
   for (auto& node_markers : markers_) {
     const Node& node = *node_markers.key;
     if (!node.IsTextNode())  // MarkerRemoverPredicate requires a Text node.
       continue;
     MarkerLists& markers = *node_markers.value;
     for (size_t marker_list_index = 0;
          marker_list_index < DocumentMarker::kMarkerTypeIndexesCount;
          ++marker_list_index) {
-      Member<MarkerList>& list = markers[marker_list_index];
+      DocumentMarkerList* list = markers[marker_list_index];
       if (!list)
         continue;
       bool removed_markers = false;
-      for (size_t j = list->size(); j > 0; --j) {
-        if (should_remove_marker(*list->at(j - 1),
+
+      DocumentMarkerVector markers_in_list;
+      list->AppendMarkersToInputList(&markers_in_list);
+
+      for (size_t j = markers_in_list.size(); j > 0; --j) {
+        if (should_remove_marker(*markers_in_list[j - 1],
                                  static_cast<const Text&>(node))) {
-          list->erase(j - 1);
+          markers_in_list.erase(j - 1);
           removed_markers = true;
         }
       }
+
+      list->Clear();
+      for (DocumentMarker* marker : markers_in_list)
+        list->Add(marker);
+
       if (removed_markers &&
           marker_list_index == DocumentMarker::kTextMatchMarkerIndex)
         InvalidatePaintForTickmarks(node);
     }
   }
 }
 
 void DocumentMarkerController::RemoveMarkers(
     DocumentMarker::MarkerTypes marker_types) {
   if (!PossiblyHasMarkers(marker_types))
@@ skipping 18 matching lines @@
   bool needs_repainting = false;
   bool node_can_be_removed;
 
   size_t empty_lists_count = 0;
   if (marker_types == DocumentMarker::AllMarkers()) {
     needs_repainting = true;
     node_can_be_removed = true;
   } else {
     MarkerLists* markers = iterator->value.Get();
 
-    for (size_t marker_list_index = 0;
-         marker_list_index < DocumentMarker::kMarkerTypeIndexesCount;
-         ++marker_list_index) {
-      Member<MarkerList>& list = (*markers)[marker_list_index];
-      if (!list || list->IsEmpty()) {
-        if (list.Get() && list->IsEmpty())
-          list.Clear();
-        ++empty_lists_count;
-        continue;
-      }
-      if (marker_types.Contains((*list->begin())->GetType())) {
+    for (DocumentMarker::MarkerType type : marker_types) {
+      size_t marker_list_index = MarkerTypeToMarkerIndex(type);
+      DocumentMarkerList* list = (*markers)[marker_list_index];
+      if (list)
         list->Clear();
-        list.Clear();
-        ++empty_lists_count;
-        needs_repainting = true;
-      }
+
+      ++empty_lists_count;
+      needs_repainting = true;
     }
 
     node_can_be_removed =
         empty_lists_count == DocumentMarker::kMarkerTypeIndexesCount;
   }
 
   if (needs_repainting) {
     const Node& node = *iterator->key;
     if (LayoutObject* layout_object = node.GetLayoutObject()) {
       layout_object->SetShouldDoFullPaintInvalidation(
@@ skipping 15 matching lines @@
     return;
   DCHECK(!markers_.IsEmpty());
 
   // outer loop: process each markered node in the document
   MarkerMap::iterator end = markers_.end();
   for (MarkerMap::iterator i = markers_.begin(); i != end; ++i) {
     const Node* node = i->key;
 
     // inner loop: process each marker in the current node
     MarkerLists* markers = i->value.Get();
-    for (size_t marker_list_index = 0;
-         marker_list_index < DocumentMarker::kMarkerTypeIndexesCount;
-         ++marker_list_index) {
-      Member<MarkerList>& list = (*markers)[marker_list_index];
-      if (!list || list->IsEmpty() ||
-          !marker_types.Contains((*list->begin())->GetType()))
+    for (DocumentMarker::MarkerType type : DocumentMarker::AllMarkers()) {
+      size_t marker_list_index = MarkerTypeToMarkerIndex(type);
+      DocumentMarkerList* list = (*markers)[marker_list_index];
+      if (!list || list->IsEmpty() || !marker_types.Contains(type))
         continue;
 
       // cause the node to be redrawn
       if (LayoutObject* layout_object = node->GetLayoutObject()) {
         layout_object->SetShouldDoFullPaintInvalidation(
             kPaintInvalidationDocumentMarkerChange);
         break;
       }
     }
   }
@@ skipping 27 matching lines @@
 
 bool DocumentMarkerController::SetMarkersActive(Node* node,
                                                 unsigned start_offset,
                                                 unsigned end_offset,
                                                 bool active) {
   MarkerLists* markers = markers_.at(node);
   if (!markers)
     return false;
 
   bool doc_dirty = false;
-  Member<MarkerList>& list =
-      (*markers)[MarkerTypeToMarkerIndex(DocumentMarker::kTextMatch)];
+  DocumentMarkerList* list =
+      markers->at(MarkerTypeToMarkerIndex(DocumentMarker::kTextMatch));
   if (!list)
     return false;
-  MarkerList::iterator start_pos =
-      std::upper_bound(list->begin(), list->end(), start_offset, EndsBefore);
-  for (MarkerList::iterator marker = start_pos; marker != list->end();
-       ++marker) {
+
+  DocumentMarkerVector markers_in_list;
+  list->AppendMarkersToInputList(&markers_in_list);
+
+  const auto start_pos = std::upper_bound(
+      markers_in_list.begin(), markers_in_list.end(), start_offset, EndsBefore);
+  for (auto marker_it = start_pos; marker_it != markers_in_list.end();
+       ++marker_it) {
     // Markers are returned in order, so stop if we are now past the specified
     // range.
-    if ((*marker)->StartOffset() >= end_offset)
+    if ((*marker_it)->StartOffset() >= end_offset)
       break;
 
-    (*marker)->SetIsActiveMatch(active);
+    (*marker_it)->SetIsActiveMatch(active);
     doc_dirty = true;
   }
 
   // repaint the affected node
   if (doc_dirty && node->GetLayoutObject()) {
     node->GetLayoutObject()->SetShouldDoFullPaintInvalidation(
         kPaintInvalidationDocumentMarkerChange);
   }
   return doc_dirty;
 }
 
 #ifndef NDEBUG
 void DocumentMarkerController::ShowMarkers() const {
   StringBuilder builder;
   MarkerMap::const_iterator end = markers_.end();
   for (MarkerMap::const_iterator node_iterator = markers_.begin();
        node_iterator != end; ++node_iterator) {
     const Node* node = node_iterator->key;
     builder.Append(String::Format("%p", node));
     MarkerLists* markers = markers_.at(node);
     for (size_t marker_list_index = 0;
          marker_list_index < DocumentMarker::kMarkerTypeIndexesCount;
          ++marker_list_index) {
-      Member<MarkerList>& list = (*markers)[marker_list_index];
-      for (unsigned marker_index = 0; list.Get() && marker_index < list->size();
-           ++marker_index) {
-        DocumentMarker* marker = list->at(marker_index).Get();
+      DocumentMarkerList* list = markers->at(marker_list_index);
+      DocumentMarkerVector markers_in_list;
+      list->AppendMarkersToInputList(&markers_in_list);
+      for (unsigned marker_index = 0;
+           list && marker_index < markers_in_list.size(); ++marker_index) {
+        DocumentMarker* marker = markers_in_list[marker_index];
         builder.Append(" ");
         builder.AppendNumber(marker->GetType());
         builder.Append(":[");
         builder.AppendNumber(marker->StartOffset());
         builder.Append(":");
         builder.AppendNumber(marker->EndOffset());
         builder.Append("](");
         builder.AppendNumber(marker->IsActiveMatch());
         builder.Append(")");
       }
@@ skipping 12 matching lines @@
                                                       unsigned new_length) {
   if (!PossiblyHasMarkers(DocumentMarker::AllMarkers()))
     return;
   DCHECK(!markers_.IsEmpty());
 
   MarkerLists* markers = markers_.at(node);
   if (!markers)
     return;
 
   bool did_shift_marker = false;
-  for (MarkerList* list : *markers) {
+  for (DocumentMarkerList* list : *markers) {
     if (!list)
       continue;
 
-    for (MarkerList::iterator it = list->begin(); it != list->end(); ++it) {
-      RenderedDocumentMarker& marker = **it;
-      Optional<DocumentMarker::MarkerOffsets> result =
-          marker.ComputeOffsetsAfterShift(offset, old_length, new_length);
-      if (result == WTF::kNullopt) {
-        list->erase(it - list->begin());
-        --it;
-        did_shift_marker = true;
-        continue;
-      }
-
-      if (marker.StartOffset() != result.value().start_offset ||
-          marker.EndOffset() != result.value().end_offset) {
-        did_shift_marker = true;
-        marker.SetStartOffset(result.value().start_offset);
-        marker.SetEndOffset(result.value().end_offset);
-      }
-    }
+    did_shift_marker =
+        list->ShiftMarkers(offset, old_length, new_length) || did_shift_marker;
   }
 
   if (!did_shift_marker)
     return;
   if (!node->GetLayoutObject())
     return;
   InvalidateRectsForMarkersInNode(*node);
   // repaint the affected node
   node->GetLayoutObject()->SetShouldDoFullPaintInvalidation();
 }
 
 }  // namespace blink
 
 #ifndef NDEBUG
 void showDocumentMarkers(const blink::DocumentMarkerController* controller) {
   if (controller)
     controller->ShowMarkers();
 }
 #endif