Issue 2812373002: Unregister from network changes on destroy in ContextualSearchTabHelper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Created:
3 years, 8 months ago by Yusuf

Modified:
3 years, 8 months ago

Reviewers:

CC:
chromium-reviews, twellington+watch_chromium.org, donnd+watch_chromium.org, agrieve+watch_chromium.org

Target Ref:
refs/branch-heads/3029

Project:
chromium

Visibility:
Public.

Unregister from network changes on destroy in ContextualSearchTabHelper This causes us to leak ChromeActivity instances and all the views associated with them. In general we should always make sure to unregister notifiers from application level singletons on destroy. BUG=710612 Review-Url: https://codereview.chromium.org/2812143002 Cr-Commit-Position: refs/heads/master@{#463855} Committed: https://chromium.googlesource.com/chromium/src/+/810b810269e4329d50c089c26d77f47ea89b61ef patch from issue 2812143002 at patchset 1 (http://crrev.com/2812143002#ps1)

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTabHelper.java	View		1 chunk	+3 lines, -0 lines	0 comments	Download