Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2812323002: Fix look-ahead parsing code in the VM (fixes #29243). (Closed)

Created:
3 years, 8 months ago by regis
Modified:
3 years, 8 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix look-ahead parsing code in the VM (fixes #29243). Add regression test. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/25dbc9b28adb004894e002301cd21ae7297c1d7c

Patch Set 1 #

Patch Set 2 : update status files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -5 lines) Patch
M runtime/vm/parser.cc View 2 chunks +12 lines, -5 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language_kernel.status View 1 1 chunk +1 line, -0 lines 0 comments Download
A tests/language/regress_29243_test.dart View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
regis
3 years, 8 months ago (2017-04-12 16:28:12 UTC) #2
siva
LGTM. You may have to adjust the status file for this new test as dart2js ...
3 years, 8 months ago (2017-04-12 17:46:36 UTC) #3
regis
On 2017/04/12 17:46:36, siva wrote: > LGTM. > > You may have to adjust the ...
3 years, 8 months ago (2017-04-12 17:59:19 UTC) #4
regis
3 years, 8 months ago (2017-04-12 18:04:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
25dbc9b28adb004894e002301cd21ae7297c1d7c.

Powered by Google App Engine
This is Rietveld 408576698