third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc - Issue 2812313002: [scheduler] Remove blink::scheduler::TaskQueue from public API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc

Issue 2812313002: [scheduler] Remove blink::scheduler::TaskQueue from public API. (Closed)

Patch Set: Rebased & addressed skyostil@'s comment Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.cc ('k') | third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc

diff --git a/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc b/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc

index 277ff6abe666bd8f1596c0c0006ad7bafa03315c..1814fbc11b6df73dcc1a8097b6e4b9ba3ec370a8 100644

--- a/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc

+++ b/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc

@@ -77,7 +77,7 @@ class TaskQueueThrottlerTest : public testing::Test {

mock_task_runner_, base::MakeUnique<TestTimeSource>(clock_.get()));

scheduler_.reset(new RendererSchedulerImpl(delegate_));

task_queue_throttler_ = scheduler_->task_queue_throttler();

- timer_queue_ = scheduler_->NewTimerTaskRunner(TaskQueue::QueueType::TEST);

+ timer_queue_ = scheduler_->NewTimerTaskQueue(TaskQueue::QueueType::TEST);

}

void TearDown() override {

@@ -663,7 +663,7 @@ TEST_F(TaskQueueThrottlerTest, TwoQueuesTimeBudgetThrottling) {

std::vector<base::TimeTicks> run_times;

scoped_refptr<TaskQueue> second_queue =

- scheduler_->NewTimerTaskRunner(TaskQueue::QueueType::TEST);

+ scheduler_->NewTimerTaskQueue(TaskQueue::QueueType::TEST);

CPUTimeBudgetPool* pool =

task_queue_throttler_->CreateCPUTimeBudgetPool("test");

@@ -983,7 +983,7 @@ TEST_F(TaskQueueThrottlerTest, DisabledQueueThenEnabledQueue) {

std::vector<base::TimeTicks> run_times;

scoped_refptr<TaskQueue> second_queue =

- scheduler_->NewTimerTaskRunner(TaskQueue::QueueType::TEST);

+ scheduler_->NewTimerTaskQueue(TaskQueue::QueueType::TEST);

task_queue_throttler_->IncreaseThrottleRefCount(timer_queue_.get());

task_queue_throttler_->IncreaseThrottleRefCount(second_queue.get());

@@ -1019,7 +1019,7 @@ TEST_F(TaskQueueThrottlerTest, TwoBudgetPools) {

std::vector<base::TimeTicks> run_times;

scoped_refptr<TaskQueue> second_queue =

- scheduler_->NewTimerTaskRunner(TaskQueue::QueueType::TEST);

+ scheduler_->NewTimerTaskQueue(TaskQueue::QueueType::TEST);

CPUTimeBudgetPool* pool1 =

task_queue_throttler_->CreateCPUTimeBudgetPool("test");